Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Baremetal] Haproxy add support for IPv6 frontend #1256

Merged
merged 1 commit into from Dec 4, 2019
Merged

[Baremetal] Haproxy add support for IPv6 frontend #1256

merged 1 commit into from Dec 4, 2019
+3 −3

Conversation

yboaron
Copy link
Contributor

@yboaron yboaron commented Nov 10, 2019

- What I did

- How to verify it

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 10, 2019
@yboaron
Copy link
Contributor Author

yboaron commented Nov 10, 2019

/cc @celebdor

@yboaron
Copy link
Contributor Author

yboaron commented Nov 12, 2019

/retest

@yboaron
Copy link
Contributor Author

yboaron commented Nov 17, 2019

/cc @bcrochet

@yboaron
Copy link
Contributor Author

yboaron commented Nov 17, 2019

/cc @cybertron

@celebdor
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2019
@celebdor
Copy link
Contributor

/assign @kikisdeliveryservice

@runcom
Copy link
Member

runcom commented Nov 19, 2019

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2019
@runcom
Copy link
Member

runcom commented Nov 19, 2019 •
edited

/hold

since freeze unless there's a BZ

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2019
@kikisdeliveryservice
Copy link
Contributor

/skip

@kikisdeliveryservice
Copy link
Contributor

this can now merge into master.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2019
@kikisdeliveryservice
Copy link
Contributor

actually i see an issue here
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2019
kikisdeliveryservice
kikisdeliveryservice previously requested changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yboaron : you again have a commit by root

please double check your PRs to make sure you are committing as yourself as this happens regularly on your PRs

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2019
@yboaron
Copy link
Contributor Author

yboaron commented Nov 28, 2019

@kikisdeliveryservice, Ooops, sorry about that. I updated the commit's author.

@sinnykumari
Copy link
Contributor

/lgtm

Commit author seems to have been fixed. Will let Kirsten do final check and lift hold.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice kikisdeliveryservice removed the request for review from LorbusChris December 4, 2019 03:32
@kikisdeliveryservice
Copy link
Contributor

/test e2e-aws

@kikisdeliveryservice
Copy link
Contributor

/skip

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 4, 2019 •
edited

@yboaron: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere dffdf451f90974033566756b2cd1af1ef57c136e link /test e2e-vsphere
ci/prow/e2e-aws-scaleup-rhel7 b973318 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b1dab06 into openshift:master Dec 4, 2019
@cybertron
Copy link
Member

/cherrypick release-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 22, 2020
Closed
@openshift-cherrypick-robot
Copy link

@cybertron: new pull request created: #1401

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cybertron cybertron mentioned this pull request Feb 10, 2020
Closed
mandre added a commit to mandre/machine-config-operator that referenced this pull request Feb 18, 2020
@mandre
OpenStack: Keepalived add support for IPv6
792d496 
This ports the BM fix from
openshift#1256 to
OpenStack platform
@mandre mandre mentioned this pull request Feb 18, 2020
Merged
vrutkovs pushed a commit to vrutkovs/machine-config-operator that referenced this pull request Mar 1, 2020
@mandre @vrutkovs
OpenStack: Keepalived add support for IPv6
df45140 
This ports the BM fix from
openshift#1256 to
OpenStack platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celebdor celebdor Awaiting requested review from celebdor

@runcom runcom Awaiting requested review from runcom

@bcrochet bcrochet Awaiting requested review from bcrochet

@cybertron cybertron Awaiting requested review from cybertron

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@celebdor celebdor

@sinnykumari sinnykumari

@kikisdeliveryservice kikisdeliveryservice

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@yboaron @celebdor @runcom @kikisdeliveryservice @sinnykumari @openshift-ci-robot @openshift-bot @cybertron @openshift-cherrypick-robot @openshift-merge-robot