Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/README: fix broken links #1277

Merged
merged 1 commit into from Dec 4, 2019

Conversation

dustymabe
Copy link
Member

Use absolute paths from the toplevel of the git repo instead of
relative paths because the README exists in the docs directory but
is symlinked from the toplevel of the repo.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 20, 2019
Use absolute paths from the toplevel of the git repo instead of
relative paths because the README exists in the docs directory but
is symlinked from the toplevel of the repo.
@kikisdeliveryservice
Copy link
Contributor

Closing since we already have a PR where we're hashing this out. See: #1259

@kikisdeliveryservice
Copy link
Contributor

/skip

1 similar comment
@kikisdeliveryservice
Copy link
Contributor

/skip

@kikisdeliveryservice
Copy link
Contributor

Double checked this, and looks good to go! Tyvm

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2019
@kikisdeliveryservice
Copy link
Contributor

/skip

@kikisdeliveryservice
Copy link
Contributor

/test e2e-gcp-upgrade

@kikisdeliveryservice
Copy link
Contributor

/override e2e-gcp-upgrade

@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-gcp-upgrade

Only the following contexts were expected:

  • ci/prow/build-rpms-from-tar
  • ci/prow/e2e-aws-scaleup-rhel7
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/e2e-vsphere
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • tide

In response to this:

/override e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

/override ci/prow/e2e-gcp-upgrade

@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-gcp-upgrade

In response to this:

/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d604e8a into openshift:master Dec 4, 2019
@openshift-ci-robot
Copy link
Contributor

@dustymabe: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere 136ef33 link /test e2e-vsphere
ci/prow/e2e-gcp-upgrade 136ef33 link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants