Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1775647: pkg/daemon: randomize pivot container name #1285

Merged
merged 1 commit into from Dec 4, 2019

Conversation

@runcom
Copy link
Member

runcom commented Nov 22, 2019

If podman has a bug and cannot cleanup container names, we'll be stuck
in the update process as seen in
https://bugzilla.redhat.com/show_bug.cgi?id=1775647.
Randomize container names with UUID to avoid that and I think it's
generally better to do this w/o cleaning up at the beginning every time.

The linked bug won't be closed by this, just using it to attach to it so we can merge as part of that. The podman fix, if any, will close it.

Signed-off-by: Antonio Murdaca runcom@linux.com

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 22, 2019

@runcom: This pull request references Bugzilla bug 1775647, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.2.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1775647: pkg/daemon: randomize pivot container name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom

This comment has been minimized.

Copy link
Member Author

runcom commented Nov 22, 2019

/bugzilla refresh

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 22, 2019

@runcom: This pull request references Bugzilla bug 1775647, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 22, 2019

@runcom: This pull request references Bugzilla bug 1775647, which is valid.

In response to this:

Bug 1775647: pkg/daemon: randomize pivot container name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/daemon/rpm-ostree.go Outdated Show resolved Hide resolved
If podman has a bug and cannot cleanup container names, we'll be stuck
in the update process as seen in
https://bugzilla.redhat.com/show_bug.cgi?id=1775647.
Randomize container names with UUID to avoid that and I think it's
generally better to do this w/o cleaning up at the beginning every time.

Signed-off-by: Antonio Murdaca <runcom@linux.com>
@runcom runcom force-pushed the runcom:random-pivot-cname branch from fd0a91a to c2f5c8f Nov 22, 2019
Copy link
Member

ashcrow left a comment

Looks good to me

@runcom

This comment has been minimized.

Copy link
Member Author

runcom commented Nov 22, 2019

/skip

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Nov 22, 2019

Will defer to @kikisdeliveryservice for LGTM

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Nov 27, 2019

/skip

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Nov 27, 2019

this LGTM but letting colin do final review/ check to see if any objections

/assign @cgwalters

@cgwalters

This comment has been minimized.

Copy link
Member

cgwalters commented Dec 2, 2019

/lgtm
(In the future I want to move this code natively into rpm-ostree FWIW and when we do so we should likely entirely avoid the default podman storage and use e.g. /run/rpm-ostree/containers-storage or something like that so that we can't hit incompatibilities like this)

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Dec 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ashcrow,cgwalters,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Dec 2, 2019

/skip

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

20 similar comments
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Dec 3, 2019

/test e2e-gcp-op

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Dec 3, 2019

/test e2e-aws

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Dec 3, 2019

unrelated failures bc of course..

/test e2e-gcp-op

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Dec 3, 2019

/test e2e-aws

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Dec 3, 2019

@runcom: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 c2f5c8f link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-vsphere c2f5c8f link /test e2e-vsphere

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Dec 4, 2019

vpc/subnet issues

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit fcf88e1 into openshift:master Dec 4, 2019
9 of 10 checks passed
9 of 10 checks passed
ci/prow/e2e-vsphere Job failed.
Details
ci/prow/build-rpms-from-tar Context retired without replacement.
ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-scaleup-rhel7 Skipped
ci/prow/e2e-gcp-op Job succeeded.
Details
ci/prow/e2e-gcp-upgrade Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
ci/prow/verify Job succeeded.
Details
tide In merge pool.
Details
@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Dec 4, 2019

@runcom: All pull requests linked via external trackers have merged. Bugzilla bug 1775647 has been moved to the MODIFIED state.

In response to this:

Bug 1775647: pkg/daemon: randomize pivot container name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.