Bug 1777082: set vsphere as provider #1291
Conversation
Bug 1776773: volume cannot mount to node after upgrade Set cloudProvider to VSphere in the kubelet configs.
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@ericavonb: This pull request references Bugzilla bug 1776773, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
size/XS
|
/bugzilla refresh |
|
@kikisdeliveryservice: This pull request references Bugzilla bug 1776773, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kikisdeliveryservice
requested review from
gnufied and
kikisdeliveryservice
and removed request for
ashcrow and
cgwalters
|
would be nice to see/test if vsphere is also setting the cloud-provider-config ? |
|
/bugzilla refresh |
|
@kikisdeliveryservice: This pull request references Bugzilla bug 1776773, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kikisdeliveryservice
changed the title
|
@ericavonb: This pull request references Bugzilla bug 1777082, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@ericavonb: This pull request references Bugzilla bug 1777082, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
ok, made a 4.4 bz so we can backport.. /bugzilla refresh |
|
@kikisdeliveryservice: This pull request references Bugzilla bug 1777082, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
We really need a e2e-vsphere job for mco. I was starting to make changes unless someone else wants to. |
|
@kikisdeliveryservice: This pull request references Bugzilla bug 1777082, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/rename Bug 1777082: set vsphere as provider |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@ericavonb: This pull request references Bugzilla bug 1777082, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
@ericavonb: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
spoke to @jcpowermac and he's going to add a e2e-vsphere test like we have for openstack: https://github.com/openshift/release/blob/master/ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml#L362 once that gets done we'll test that way before merging. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
FYI: RHEL7 scaleup test failing across PRs due to BZ1777034 (unrelated to this PR and MCO), seeing same err: |
|
/test e2e-vsphere |
|
/skip e2e-aws-scaleup-rhel7 |
|
/skip |
|
Might need the inflight openshift/release#6131 to merge to have enough clusters for e2e-vsphere to run. |
|
Going to remove the hold so that this can be merged/LGTM'ed by @jcpowermac / @gnufied as they see fit based on the results of e2e-vsphere runs. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
it mostly looks good to me. Although - I do not understand MCO code well enough. :-) |
|
/test e2e-vsphere |
|
@ericavonb the statefulset and PVC tests that were failing succeeded. I think this PR is good to go. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ericavonb, jcpowermac, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@ericavonb: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@ericavonb: All pull requests linked via external trackers have merged. Bugzilla bug 1777082 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ericavonb: new pull request created: #1293 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fix(pkg/controller/template/render): set vsphere as provider
Set cloudProvider to VSphere in the kubelet configs.
Fixes Bug 1777082: volume cannot mount to node after upgrade