New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1783585: CRI-O: Set conmon_cgroup to "pod" #1296
Bug 1783585: CRI-O: Set conmon_cgroup to "pod" #1296
Conversation
Upstream cri-o has moved to set the conmon-cgroup to system.slice by default. But we want the conmon cgroup to be under the pod by default in OpenShift. So explicitly setting it here in the MCO templates for crio.conf Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
/retest |
/skip |
/retest |
/retest |
@umohnani8: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-aws |
/test e2e-gcp-op |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on behalf of @mrunalp 😸
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, kikisdeliveryservice, mrunalp, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick fcos |
@LorbusChris: new pull request created: #1308 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.3 |
@rphillips: new pull request created: #1344 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retitle Bug 1783585: CRI-O: Set conmon_cgroup to "pod" |
@umohnani8: All pull requests linked via external trackers have merged. Bugzilla bug 1783585 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Upstream cri-o has moved to set the conmon-cgroup to system.slice
by default. But we want the conmon cgroup to be under the pod by
default in OpenShift. So explicitly setting it here in the MCO
templates for crio.conf
Signed-off-by: Urvashi Mohnani umohnani@redhat.com
- What I did
- How to verify it
- Description for the changelog