Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kernelType to MachineConfig #1330

Merged
merged 3 commits into from Jan 23, 2020
Merged

Add kernelType to MachineConfig #1330

merged 3 commits into from Jan 23, 2020

Conversation

sinnykumari
Copy link
Contributor

@sinnykumari sinnykumari commented Dec 12, 2019 •
edited

By default we use traditional kernel on RHCOS system. With this,
one can create a MachineConfig specifying kernelType: realtime .
Once this MachineConfig is applied to OpenShift cluster,
targetted RHCOS node should switch to using realtime kernel.

Currently, realtime kernel packages are shipped as rpm files in
RHCOS OSContainer. MCO fetches those rpms from OSContainer and
uses rpm-ostree to layer realtime kernel on host.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 12, 2019
cgwalters
cgwalters reviewed Dec 12, 2019
View reviewed changes
pkg/daemon/update.go Outdated Show resolved Hide resolved
ericavonb
ericavonb reviewed Dec 12, 2019
View reviewed changes
pkg/daemon/update.go Outdated Show resolved Hide resolved
kikisdeliveryservice
kikisdeliveryservice reviewed Dec 12, 2019
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sinnykumari is there any background on this change?

Also I would do an e2e on this when you are finished.

@sinnykumari sinnykumari changed the title WIP: Add realtime to MachineConfig WIP: Add kernelType to MachineConfig Dec 17, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2019
cynepco3hahue pushed a commit to cynepco3hahue/performance-addon-operators that referenced this pull request Dec 31, 2019
Introduce RepoURL under the API
bdbd5f5 
We should provide the real time kernel install and update pathes until the
openshift/machine-config-operator#1330 will be merged.

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
cynepco3hahue pushed a commit to cynepco3hahue/performance-addon-operators that referenced this pull request Jan 2, 2020
Introduce RepoURL under the API
0f18cf3 
We should provide the real time kernel install and update pathes until the
openshift/machine-config-operator#1330 will be merged.

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@slintes slintes mentioned this pull request Jan 10, 2020
Merged
3 tasks
@sinnykumari sinnykumari changed the title WIP: Add kernelType to MachineConfig Add kernelType to MachineConfig Jan 16, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2020
@sinnykumari
Copy link
Contributor Author

There were lot of changes since the original implementation were made. To avoid confusion and get a fresh review, have done force push. This should be good for review now.

runcom
runcom reviewed Jan 16, 2020
View reviewed changes
pkg/daemon/update.go Outdated Show resolved Hide resolved
@runcom
Copy link
Member

runcom commented Jan 16, 2020

just a super minor nit but the rest looks super sane
/approve

will let others to review again before getting this in

cgwalters
cgwalters reviewed Jan 16, 2020
View reviewed changes
pkg/daemon/update.go Outdated Show resolved Hide resolved
pkg/daemon/update.go Outdated Show resolved Hide resolved
pkg/daemon/update.go Outdated Show resolved Hide resolved
pkg/daemon/update.go Outdated Show resolved Hide resolved
pkg/daemon/update.go Outdated Show resolved Hide resolved
pkg/daemon/update.go Show resolved Hide resolved
pkg/daemon/update.go Outdated Show resolved Hide resolved
pkg/daemon/update.go Outdated Show resolved Hide resolved
pkg/daemon/update.go Outdated Show resolved Hide resolved
@cgwalters
Copy link
Member

Looking at this, I can definitely see the cost to the MCO of shipping kernel-rt the way we are; it would be simplest with two osImageURL, a bit less simple with two refs in the same container. But there'd be a lot of tech debt to pay down to implement that buildsystem side.

@sinnykumari
pkg/controller: Validate whatever we can in MachineConfigs
5e6b3dc 
Also, while updating the RHCOS machine with realtime kernel,
check if new kernel-rt packages are available. Update
rt-kernel on host only when OS update contains updated kernel-rt.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@sinnykumari
Copy link
Contributor Author

Retrying as it says level=error msg="Error: ResourceLimitExceeded: Task limit exceeded"

/test e2e-aws
/test e2e-aws-scaleup-rhel7

@runcom
Copy link
Member

runcom commented Jan 22, 2020

/skip

1 similar comment
@runcom
Copy link
Member

runcom commented Jan 22, 2020

/skip

@sinnykumari sinnykumari force-pushed the realtime-machineconfig branch 3 times, most recently from b74cd5c to 67f3f11 Compare January 23, 2020 06:32
@sinnykumari
Copy link
Contributor Author

I moved following rpm-ostree command execution back in the respective if condition so that we never accidentally run it.

if err := exec.Command("rpm-ostree", args...).Run(); err != nil {
    return fmt.Errorf("Failed to execute rpm-ostree %+q : %v", args, err)
}

@runcom
Copy link
Member

runcom commented Jan 23, 2020

/skip

runcom
runcom reviewed Jan 23, 2020
View reviewed changes
pkg/daemon/update.go Outdated Show resolved Hide resolved
@runcom
Copy link
Member

runcom commented Jan 23, 2020

op e2e failing for the usual flakes

level=error msg="Error: Error applying IAM policy to project \"openshift-gce-devel-ci\": Too many conflicts.  Latest error: Error setting IAM policy for project \"openshift-gce-devel-ci\": googleapi: Error 409: There were concurrent policy changes. Please retry the whole read-modify-write with exponential backoff., aborted"

@sinnykumari
Copy link
Contributor Author

/retest e2e-gcp-op

@sinnykumari
Copy link
Contributor Author

/test e2e-gcp-op

@MarSik
Copy link
Contributor

MarSik commented Jan 23, 2020

/retest

@runcom
Copy link
Member

runcom commented Jan 23, 2020

/lgtm
/skip

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@sinnykumari: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 8ee18d9 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@runcom
Copy link
Member

runcom commented Jan 23, 2020

/skip

@runcom runcom removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit d27a05d into openshift:master Jan 23, 2020
@slintes slintes mentioned this pull request Jan 23, 2020
Merged
@slintes slintes mentioned this pull request Feb 13, 2020
Merged
4 tasks
@miabbott miabbott mentioned this pull request Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow left review comments

@cgwalters cgwalters cgwalters left review comments

@runcom runcom runcom left review comments

@ericavonb ericavonb ericavonb left review comments

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice requested changes

@miabbott miabbott miabbott left review comments

Assignees

@runcom runcom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet