New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1782893: vendor: bring in ReservedSystemCPUs changes #1331
Conversation
@runcom: This pull request references Bugzilla bug 1779348, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
// This ReservedSystemCPUs option specifies the cpu list reserved for the host level system threads and kubernetes related threads. | ||
// This provide a "static" CPU list rather than the "dynamic" list by system-reserved and kube-reserved. | ||
// This option overwrites CPUs provided by system-reserved and kube-reserved. | ||
ReservedSystemCPUs string `json:"reservedSystemCPUs,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@runcom Thanks! It looks like exactly what we need. |
@runcom: This pull request references Bugzilla bug 1782893, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Antonio Murdaca <runcom@linux.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, runcom, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Attached bug has all the relevant information but this isn't doing more than just vendoring some k8s deps to make it work.
Signed-off-by: Antonio Murdaca runcom@linux.com