pkg/server: save the bootstrap MC content #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
@cgwalters I'd love if you can have a super fast look at this |
openshift-ci-robot
added
the
approved
cgwalters
reviewed
Jan 16, 2020
There was a problem hiding this comment.
Seems OK to me short term. Conceptually though...there are two things:
- The Ignition
- The rest of the MC, which we already have in
-encapsulated.json
So if we came up with a mechanism to save the Ignition, we could reassemble the two. See this issue for some recent discussion of saving Ignition.
runcom
force-pushed
the
save-bootstrap-mc
branch
from
c22d3ba
to
32ee7ec
Compare
|
/test e2e-gcp-op |
|
a daemon got cut off during eviction durign reboot and mcc see: retesting |
|
I dont think that it's specific to the PR (ill check) but seeing in runs that this shutdown doesn't seem to occur and then the mcp test times out.... Looking a little more |
|
Seeing dns issues: But also seeing a degraded node-exporter. Will poke around BZ to see if something is open... |
|
MCO isn't degraded, it's just timing out. /test e2e-gcp-op |
|
Opened BZ 1792033 for that node-exporter error. |
This patch injects the current machine config served by the MCS into the ignition config to have it on disk for later comparisons. This isn't making any difference between bootstrap and cluster but I'm naming this commit with bootstrap as this will be extremely helpful as a stopgap to investigate installer & MCO drifts. By having the MC content on disk, if a drift happens, we can collect the MC with must-gather and just compare it with what the MCO in the cluster is generating. Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
force-pushed
the
save-bootstrap-mc
branch
from
32ee7ec
to
ccf9a24
Compare
|
can we move on with #1376 to at least have some data to ease debug till we come up with a stronger solution to auto-reconcile as David suggested? |
|
LGTM deferring to colin to ensure he has no further comments /assign @cgwalters |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch injects the current machine config served by the MCS
into the ignition config to have it on disk for later comparisons.
This isn't making any difference between bootstrap and cluster
but I'm naming this commit with bootstrap as this will be
extremely helpful as a stopgap to investigate installer & MCO drifts.
By having the MC content on disk, if a drift happens, we can collect
the MC with must-gather and just compare it with what the MCO in the
cluster is generating.
Signed-off-by: Antonio Murdaca runcom@linux.com