Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1803232: Fixed hardcoded ingress VIP password #1380

Merged
merged 1 commit into from Mar 9, 2020
Merged

Bug 1803232: Fixed hardcoded ingress VIP password #1380

merged 1 commit into from Mar 9, 2020

Conversation

e-minguez
Copy link
Contributor

Fixes #1379

- What I did
The current keepalived ingress VIP password is hardcoded so I've changed to follow the other VIP passwords.

- How to verify it
Deploy a cluster and observe the /etc/keepalived/keepalived.conf file

- Description for the changelog
Fixed hardcoded ingress VIP password

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2020
@e-minguez
Copy link
Contributor Author

/retest

@cgwalters
Copy link
Member

I'm not very familiar with keepalived; only skimmed some of the docs. But we're just changing from a truly hardcoded password to one that is easily guessable. Is it expected that in practice vrrpd is on a trusted network or something?

@e-minguez
Copy link
Contributor Author

cc @celebdor @yboaron @bcrochet

@celebdor
Copy link
Contributor

/assign yboaron

@yboaron
Copy link
Contributor

yboaron commented Feb 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020
@mandre
Copy link
Member

mandre commented Feb 4, 2020

/test e2e-openstack

@celebdor
Copy link
Contributor

/lgtm

@celebdor
Copy link
Contributor

/retest

@mandre
Copy link
Member

mandre commented Feb 14, 2020

/lgtm

@celebdor
Copy link
Contributor

/assign kikisdeliveryservice

@kikisdeliveryservice
Copy link
Contributor

we need a BZ for this

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2020
@kikisdeliveryservice
Copy link
Contributor

/skip

@celebdor
Copy link
Contributor

/retitle Bug 1803232: Fixed hardcoded ingress VIP password

@openshift-ci-robot openshift-ci-robot changed the title Fixed hardcoded ingress VIP password Bug 1803232: Fixed hardcoded ingress VIP password Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

@e-minguez: This pull request references Bugzilla bug 1803232, which is valid. The bug has been moved to the POST state.

In response to this:

Bug 1803232: Fixed hardcoded ingress VIP password

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 14, 2020
@celebdor
Copy link
Contributor

/approve

@kikisdeliveryservice
Copy link
Contributor

ty @celebdor !

/approve

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@e-minguez
Copy link
Contributor Author

Is there any way to skip unrelated tests?

@sinnykumari
Copy link
Contributor

e2e-gcp-op failure could be related to #1545 (comment)

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@runcom
Copy link
Member

runcom commented Mar 9, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 9, 2020 •
edited

@e-minguez: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 2de7aea link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ae8e1f4 into openshift:master Mar 9, 2020
@openshift-ci-robot
Copy link
Contributor

@e-minguez: All pull requests linked via external trackers have merged. Bugzilla bug 1803232 has been moved to the MODIFIED state.

In response to this:

Bug 1803232: Fixed hardcoded ingress VIP password

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 9, 2020
Merged
@openshift-cherrypick-robot
Copy link

@runcom: new pull request created: #1550

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet bcrochet approved these changes

@cgwalters cgwalters Awaiting requested review from cgwalters

@mandre mandre Awaiting requested review from mandre

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@mandre mandre

@celebdor celebdor

@kikisdeliveryservice kikisdeliveryservice

@yboaron yboaron

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keepalived's ingress VIP barmetal password hardcoded