Update kubelet.config for single-stack IPv6 #1381
Conversation
openshift-ci-robot
added
the
size/M
|
/approve |
openshift-ci-robot
added
the
approved
|
As you can see our testing i somehow broken at the moment =/ LGTM cc: @rphillips for viz |
|
yeah, tests broken but we're working on it /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, danwinship, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
18 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/cherry-pick release-4.3 |
|
@danwinship: new pull request created: #1538 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- What I did
In a single-stack IPv6 environment, update the
kubelet.configto pass--node-ip ::to tell it to pick an IPv6 address rather than an IPv4 address for the node address. (Depends on openshift/origin#24401 which is why this was not merged with the other IPv6 changes before (#1211).)Specifically, this fixes the problem of trying to bring up a single-stack IPv6 cluster on a node that happens to have IPv4 addresses that you aren't using. (eg, this is necessary for testing single-stack IPv6 on AWS or Azure, since there is no way to bring up a node there there doesn't have an IPv4 address.) By default, if you don't specify an explicit
--node-ip, and there are IPv4 node IPs addresses present, then kubelet will pick the node's default IPv4 address to be its primary IP, even if the cluster and service CIDRs are IPv6-only (which will then result in a cluster that doesn't work). The newly added--node-ip ::option tells it to pick the node's default IPv6 address instead.- How to verify it
... You can't easily. But this has been part of the IPv6 testing environment. And it has unit tests!
- Description for the changelog
In a single-stack IPv6 environment, kubelet will be configured to pick an IPv6 address rather than an IPv4 one for the default node IP (even if there are IPv4 addresses on the node).