Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update codegen script to be compatible with go mod vendor #1384

Merged
merged 1 commit into from Jan 23, 2020
Merged

Fix update codegen script to be compatible with go mod vendor #1384

merged 1 commit into from Jan 23, 2020

Conversation

LorbusChris
Copy link
Member

@LorbusChris LorbusChris commented Jan 18, 2020 •
edited

Manual cherry-pick from the fix @sgreene570 added on the fcos branch.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2020
@LorbusChris
Copy link
Member Author

/retest

3 similar comments
@LorbusChris
Copy link
Member Author

/retest

@LorbusChris
Copy link
Member Author

/retest

@LorbusChris
Copy link
Member Author

/retest

@yuqi-zhang
Copy link
Contributor

The failure seems to be pretty consistently the same, for example, on upgrade:
ERROR: (gcloud.compute.instance-groups.list-instances) could not parse resource []
Not sure if that's related though... I see tests passing on some other PRs so not sure why this is having trouble

@LorbusChris
Copy link
Member Author

I don't see how that could be related :/

@LorbusChris
Copy link
Member Author

/retest

@sinnykumari
Copy link
Contributor

I don't see how that could be related :/

It's not this PR specific, gcp tests are failing for other PRs in master too.

@LorbusChris
Copy link
Member Author

/retest

1 similar comment
@LorbusChris
Copy link
Member Author

/retest

@sgreene570
Copy link
Contributor

#1370 for context, this change won't affect master until the vendor folder is updated.

yuqi-zhang
yuqi-zhang approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 181d855 into openshift:master Jan 23, 2020
@LorbusChris LorbusChris deleted the update-codegen-fix branch February 24, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@ericavonb ericavonb Awaiting requested review from ericavonb

Assignees

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@LorbusChris @yuqi-zhang @sinnykumari @sgreene570 @openshift-ci-robot @openshift-bot @openshift-merge-robot