Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAProxy infra pod: Make v4/v6 compatible #1394

Merged
merged 1 commit into from Jan 22, 2020
Merged

HAProxy infra pod: Make v4/v6 compatible #1394

merged 1 commit into from Jan 22, 2020

Conversation

celebdor
Copy link
Contributor

Have the bind to all interfaces statements listen to both IPv4 and IPv6 so it
works both on single and dual stack deployments.

Fixes: #1389

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2020
@celebdor
Copy link
Contributor Author

/assign @rgolangh
/assign @yboaron

@celebdor
Copy link
Contributor Author

/assign @Fedosin

@celebdor
HAProxy infra pod: Make v4/v6 compatible
da71b4a 
Have the bind to all interfaces statements listen to both IPv4 and IPv6 so it
works both on single and dual stack deployments.

Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
@russellb
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@celebdor
Copy link
Contributor Author

/assign runcom

@Fedosin
Copy link
Contributor

Fedosin commented Jan 21, 2020

/test e2e-openstack

cybertron
cybertron approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Fedosin
Copy link
Contributor

Fedosin commented Jan 21, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celebdor, cybertron, Fedosin, kikisdeliveryservice, russellb, yboaron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit aeef8e5 into openshift:master Jan 22, 2020
@celebdor
Copy link
Contributor Author

/cherrypick release-4.3

@openshift-cherrypick-robot
Copy link

@celebdor: #1394 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	templates/master/00-master/baremetal/files/baremetal-haproxy-haproxy.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/master/00-master/baremetal/files/baremetal-haproxy-haproxy.yaml
CONFLICT (content): Merge conflict in templates/master/00-master/baremetal/files/baremetal-haproxy-haproxy.yaml
Patch failed at 0001 HAProxy infra pod: Make v4/v6 compatible

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@celebdor celebdor deleted the haproxy-ipv4v6-bind branch January 22, 2020 08:41
@celebdor celebdor mentioned this pull request Jan 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertron cybertron cybertron approved these changes

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@yboaron yboaron yboaron approved these changes

@Fedosin Fedosin Awaiting requested review from Fedosin

@runcom runcom Awaiting requested review from runcom

Assignees

@russellb russellb

@cybertron cybertron

@runcom runcom

@rgolangh rgolangh

@Fedosin Fedosin

@yboaron yboaron

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

baremetal: haproxy doesn't listen on IPv6