Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1780442: DR: allow use of local etcdctl plus version check #1397

Merged
merged 1 commit into from Jan 24, 2020
Merged

Bug 1780442: DR: allow use of local etcdctl plus version check #1397

merged 1 commit into from Jan 24, 2020

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Jan 21, 2020 •
edited

In airgap and proxy scenario, we need a simple way for allowing an alternative method of obtaining etcd client binary. In the future, this method could be considered the default. But for now we are allowing user to provide the binary in advance of running the script. This process would be part of the documentation as phase 1.

We also do not want old versions of the binary to be used so we added a version check.

This PR needs manual test/verification

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 21, 2020
@openshift-ci-robot
Copy link
Contributor

@hexfusion: This pull request references Bugzilla bug 1780442, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

WIP Bug 1780442: DR: allow use of local etcdctl plus version check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2020
@hexfusion
Copy link
Contributor Author

cc @retroflexer

@openshift-ci-robot
Copy link
Contributor

@hexfusion: An error was encountered searching for bug 1780442 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1780442?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

WIP Bug 1780442: DR: allow use of local etcdctl plus version check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@retroflexer
Copy link
Contributor

/test e2e-aws-disruptive

@hexfusion
Copy link
Contributor Author

/retest

@hexfusion hexfusion changed the title WIP Bug 1780442: DR: allow use of local etcdctl plus version check Bug 1780442: DR: allow use of local etcdctl plus version check Jan 23, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2020
@retroflexer
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@retroflexer
Copy link
Contributor

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020
@hexfusion
DR: allow use of local etcdctl plus version check
625a630 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@retroflexer
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020
@retroflexer
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@runcom
Copy link
Member

runcom commented Jan 23, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, retroflexer, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020
@kikisdeliveryservice
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cac640d into openshift:master Jan 24, 2020
@openshift-ci-robot
Copy link
Contributor

@hexfusion: All pull requests linked via external trackers have merged. Bugzilla bug 1780442 has been moved to the MODIFIED state.

In response to this:

Bug 1780442: DR: allow use of local etcdctl plus version check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion deleted the airgap branch January 24, 2020 01:40
@openshift-ci-robot
Copy link
Contributor

@hexfusion: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-disruptive cd4cd53dc2fe1dec17bc14b6cd5b911b31e77b0e link /test e2e-aws-disruptive
ci/prow/e2e-aws-scaleup-rhel7 625a630 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retroflexer retroflexer retroflexer left review comments

@cgwalters cgwalters Awaiting requested review from cgwalters

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@retroflexer retroflexer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hexfusion @openshift-ci-robot @retroflexer @runcom @kikisdeliveryservice @openshift-bot @openshift-merge-robot