daemon: Move "Validated on-disk state" log to only when we have #1416
Conversation
When the force file is present, we didn't actually validate. Obviously, this just changes logging; I was just reading the code as part of looking at https://bugzilla.redhat.com/show_bug.cgi?id=1766515
openshift-ci-robot
added
size/XS
|
/approve This should be safe to merge now but let me get back with a more concrete action on what to do here (branch isn't frozen, but we'd need a bug fix for such a change as well perhaps) |
gonna add a hold bc this prob needs a bz /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
unless you wanted to make it part of 1766515? |
|
/skip |
|
(after some chats...) PR is super tiny so it can go in as it's not really requiring a BZ /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Uhm probably need a BZ now that master has been enforced , let’s see /refresh |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
ok this can finally merge, im doing it. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cgwalters: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
When the force file is present, we didn't actually validate.
Obviously, this just changes logging; I was just reading the code
as part of looking at
https://bugzilla.redhat.com/show_bug.cgi?id=1766515