Bug 1796148: baremetal: Remove .template from path in dhcp-dhclient-conf.yaml #1419
Conversation
This appears to get written out as /etc/dhcp/dhclient.conf.template with no subsequent render-config templating to create the actual /etc/dhcp/dhclient.conf - modifying the path results in the file being correctly written.
openshift-ci-robot
added
the
size/XS
|
/lgtm |
|
/approve this is ipv6 work right? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, hardys, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
I found this while testing ipv6 but it looks like it never worked even on ipv4, AFAICT this should work fine in both cases though (and aligns with what's done and known-working on the masters) |
I think we would love a BZ if this bug is present in 4.3 and below /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retitle Bug 1796148: baremetal: Remove .template from path in dhcp-dhclient-conf.yaml |
openshift-ci-robot
changed the title
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@hardys: This pull request references Bugzilla bug 1796148, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@hardys: This pull request references Bugzilla bug 1796148, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hardys: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@hardys: All pull requests linked via external trackers have merged. Bugzilla bug 1796148 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.3 |
|
@hardys: new pull request created: #1438 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This appears to get written out as /etc/dhcp/dhclient.conf.template with no subsequent render-config templating to create the actual /etc/dhcp/dhclient.conf - modifying the path results in the file being correctly written. This ports the BM fix from openshift#1419 to OpenStack platform.
This appears to get written out as /etc/dhcp/dhclient.conf.template with no subsequent render-config templating to create the actual /etc/dhcp/dhclient.conf - modifying the path results in the file being correctly written. This ports the BM fix from openshift#1419 to OpenStack platform.
This appears to get written out as /etc/dhcp/dhclient.conf.template
with no subsequent render-config templating to create the actual
/etc/dhcp/dhclient.conf - modifying the path results in the file
being correctly written.