Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ: More about preservation of changes and the MCO #1451

Merged

Conversation

@cgwalters
Copy link
Member

cgwalters commented Feb 10, 2020

Package layering came up in a Slack conversation.

Package layering came up in a Slack conversation.
Copy link
Member

kikisdeliveryservice left a comment

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Feb 10, 2020

stop it bot!

/skip

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sinnykumari

This comment has been minimized.

Copy link
Contributor

sinnykumari commented Feb 11, 2020

/skip e2e-aws-scaleup-rhel7

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 11, 2020

@cgwalters: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 85389ef link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice

This comment has been minimized.

Copy link
Member

kikisdeliveryservice commented Feb 11, 2020

/skip

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 11, 2020

Overriding bot as this is clarifying documentation.

Another case today is that the SDN operator will extract some binaries from its container image and drop them in `/opt`.
Another case today is that the SDN operator will extract some binaries from its container image and drop them in `/opt` (which is really `/var/opt`).

Stated more generally, on an OSTree managed system, all content in `/etc` and `/var` is [preserved by default across upgrades](https://ostree.readthedocs.io/en/latest/manual/adapting-existing/).

This comment has been minimized.

Copy link
@wking

wking Feb 11, 2020

Member

Are we concerned about this floating master link? I'd have expected something pinned to a specific OSTree release.

@openshift-merge-robot openshift-merge-robot merged commit eabda8d into openshift:master Feb 11, 2020
6 checks passed
6 checks passed
ci/prow/e2e-aws-scaleup-rhel7 Skipped
ci/prow/e2e-gcp-upgrade Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
ci/prow/verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.