Bug 1801466: add owners files to master and worker kubelet templates #1453
Conversation
openshift-ci-robot
added
the
size/S
openshift-ci-robot
requested review from
mrunalp,
sjenning,
ericavonb and
kikisdeliveryservice
There was a problem hiding this comment.
shouldn't this drill down more to master/worker/ kubelet/containerruntime templates?
We have other owners in subdirs for example, see: https://github.com/openshift/machine-config-operator/blob/87e2ff958fcb0c9dd88e69f97ef3aa7bbe8f37f1/templates/master/00-master/openstack/OWNERS
rphillips
force-pushed
the
add/owners_to_configs
branch
from
478517a
to
24caee5
Compare
kikisdeliveryservice
changed the title
openshift-ci-robot
added
the
approved
rphillips
force-pushed
the
add/owners_to_configs
branch
from
24caee5
to
271b90a
Compare
rphillips
changed the title
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@rphillips: This pull request references Bugzilla bug 1801466, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@rphillips: This pull request references Bugzilla bug 1801466, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/retest |
|
@rphillips: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
👍 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, rphillips, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rphillips: All pull requests linked via external trackers have merged. Bugzilla bug 1801466 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- What I did
Add an owners file to master and worker kubelet templates.
- How to verify it
- Description for the changelog