Bug 1804944: Point etcd SRV record at master hostnames #1461
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
/lgtm |
|
/hold |
cybertron
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest The coredns-mdns change has merged so this should be good to go. |
|
I was wrong previously, we actually needed to update the vendoring in coredns too. That's now done: openshift/coredns#25 Which should mean this is good to go for real this time. |
runcom
changed the title
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@cybertron: This pull request references Bugzilla bug 1804944, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/skip |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@runcom: This pull request references Bugzilla bug 1804944, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/approve @celebdor can you give this a look for merging? |
openshift-ci-robot
added
the
approved
|
This is also gonna need a 4.4 cherry-pick for https://bugzilla.redhat.com/show_bug.cgi?id=1810663 /cherrypick release-4.4 |
|
@runcom: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, cybertron, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@cybertron: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
@cybertron: All pull requests linked via external trackers have merged. Bugzilla bug 1804944 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@runcom: new pull request created: #1537 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Our current method of mapping master hostnames to etcd-[0,1,2] records introduces undesirable restrictions on the names of master nodes. Now that cluster-etcd-operator allows us to bootstrap the etcd cluster using the SRV record, we can just point it at the masters directly and drop the extra etcd-specific record. This should eliminate the hostname requirements entirely.
This will need to wait for openshift/coredns-mdns#52 to merge since that is forcing use of the etcd record.