bug 1801397: temporarily skip setting failures on degraded machine config pool

[deads2k]

per our discussion in slack, we need this PR to skip setting degraded on machineconfigoperator when the pools are bad so that we can land openshift/cluster-etcd-operator#142 and #1465. After that, we will no longer go degraded in 4.4.

You can see an example of the condition here: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-etcd-operator/112/pull-ci-openshift-cluster-etcd-operator-master-e2e-aws/597 . The MCO is completely correct to set it, but we need to break the stalemate.

[deads2k]

/hold

holding until we're ready to merge this, but I suspect it's coming.

[kikisdeliveryservice]

reported that this test (e2e-aws-scaleup-rhel7) is always broken and but it's not reqd so..

/skip

[kikisdeliveryservice]

Also @deads2k your sync.go has some problems and won't pass verify until tweaked:

pkg/operator/sync.go:564: File is not `gofmt`-ed with `-s` (gofmt)
				degraded{
make: *** [verify] Error 1 ```

[deads2k]

/hold cancel

[deads2k]

/retest

[deads2k]

/retest

[deads2k]

/retest

[kikisdeliveryservice]

re-adding hold until it's time just as a safeguard.

/hold

[kikisdeliveryservice]

/skip

[deads2k]

/hold cancel

[runcom]

/approve
/lgtm

[openshift-ci-robot]

@deads2k: This pull request references Bugzilla bug 1801397, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

bug 1801397: temporarily skip setting failures on degraded machine config pool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deads2k]

/retest

[deads2k]

#1476 is the only commit to merge since this tested green. it isn't related. merging to get the train moving.

[openshift-ci-robot]

@deads2k: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	17d4103	link	/test e2e-aws-scaleup-rhel7
ci/prow/e2e-gcp-op	17d4103	link	/test e2e-gcp-op
ci/prow/e2e-gcp-upgrade	17d4103	link	/test e2e-gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.