Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1805393: make etcd quorum guard privileged to read files from etcd operator #1484

Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 18, 2020

paired with openshift/cluster-etcd-operator#162 to make sure the quorum guard can read the correct files off disk. We would pick this back to 4.3

/cherrypick release-4.3

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2020
@hexfusion
Copy link
Contributor

/skip

scaleup is broken

@deads2k
Copy link
Contributor Author

deads2k commented Feb 18, 2020

/retest

@kikisdeliveryservice
Copy link
Contributor

(test is broken)

/skip

@runcom
Copy link
Member

runcom commented Feb 19, 2020

/approve

@hexfusion can you bless this?

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@sinnykumari
Copy link
Contributor

I am confused that this PR is making changes to file install/0000_80_machine-config-operator_07_etcdquorumguard_deployment.yaml while PR #1477 removes the file . Do we need this change in master?

@kikisdeliveryservice
Copy link
Contributor

@deads2k we have to cherrypick this back to 4.4 now too right?

@hexfusion
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hexfusion, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Contributor

/cherrypick release-4.4

@openshift-cherrypick-robot

@hexfusion: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2020

@deads2k: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 41b22d8 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor

/cherrypick release-4.3

@openshift-cherrypick-robot

@hexfusion: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor

hexfusion commented Feb 20, 2020

I am confused that this PR is making changes to file install/0000_80_machine-config-operator_07_etcdquorumguard_deployment.yaml while PR #1477 removes the file . Do we need this change in master?

#1477 is going to be closed

@sinnykumari
Copy link
Contributor

I am confused that this PR is making changes to file install/0000_80_machine-config-operator_07_etcdquorumguard_deployment.yaml while PR #1477 removes the file . Do we need this change in master?

#1477 is going to be closed

ah ok, makes sense then.

@openshift-cherrypick-robot

@hexfusion: new pull request created: #1492

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@hexfusion: new pull request created: #1493

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor

/retitle Bug 1805393: make etcd quorum guard privileged to read files from etcd operator

@openshift-ci-robot openshift-ci-robot changed the title make etcd quorum guard privileged to read files from etcd operator Bug 1805393: make etcd quorum guard privileged to read files from etcd operator Feb 20, 2020
@openshift-ci-robot
Copy link
Contributor

@deads2k: All pull requests linked via external trackers have merged. Bugzilla bug 1805393 has been moved to the MODIFIED state.

In response to this:

Bug 1805393: make etcd quorum guard privileged to read files from etcd operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants