New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1810333: Detect default hostname in its variants #1529
Bug 1810333: Detect default hostname in its variants #1529
Conversation
/assign @yboaron @bcrochet @cybertron |
025e75e
to
70913b0
Compare
On some environments, `hostname` returns localhost whereas on others it returns `localhost.localdomain`. This commit ensures that we'll catch both. It also increases verbosity of initcontainers to ease debugging of similar issues in the future. Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
70913b0
to
1ca6640
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane. Will defer to others for second review and merge post CI.
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tested this locally and it worked fine.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, celebdor, cybertron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retitle Bug 1810333: Detect default hostname in its variants |
@celebdor: This pull request references Bugzilla bug 1810333, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.4 |
@celebdor: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.3 |
@celebdor: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@celebdor: new pull request created: #1533 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@celebdor: new pull request created: #1534 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
On some environments,
hostname
returns localhost whereas on others itreturns
localhost.localdomain
. This commit ensures that we'll catchboth.
It also increases verbosity of initcontainers to ease debugging of
similar issues in the future.