Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1810333: daemon: Always create tempfiles in target dir #1530

Merged

Commits on Mar 4, 2020

  1. daemon: Always create tempfiles in target dir

    When we go to write a file, we need to create the temporary
    file in the exact target directory, not (potentially) `/tmp`. This will
    ensure that the right SELinux label is used by default.
    
    Currently the `renameio` library's logic tries to optimize things
    by using `/tmp` if possible, otherwise the target directory.
    And without SELinux that's a sane optimization.  But we
    can't do it.
    
    Force using the target directory by passing it explicitly.
    
    Should fix a bug seen with the baremetal config which
    ended up with a `tmp_t` labeled file in `/etc`.
    cgwalters committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    57ebb74 View commit details
    Browse the repository at this point in the history