Bug 1811898: cmd/machine-config-operator: log RELEASE_VERSION when starting up

[runcom]

Other subcomponents are still following the old version logging when Raw and Hash
are sufficient for us to debug. This patch just changes the MCO itself to print
RELEASE_VERSION at startup. We might want to revisit this for all components and
bootstrap commands later but not critical either.

Signed-off-by: Antonio Murdaca runcom@linux.com

[openshift-ci-robot]

@runcom: This pull request references Bugzilla bug 1811898, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1811898: cmd/machine-config-operator: log RELEASE_VERSION when starting up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[runcom]

/retest

[yuqi-zhang]

So, if I understand this correctly os.Getenv("RELEASE_VERSION") is just getting an environment variable. In this case nothing is setting RELEASE_VERSION no? I logged in to a node and can see that its empty by default. Wouldn't this just be empty?

[runcom]

So, if I understand this correctly os.Getenv("RELEASE_VERSION") is just getting an environment variable. In this case nothing is setting RELEASE_VERSION no? I logged in to a node and can see that its empty by default. Wouldn't this just be empty?

that env is injected into the MCO pod (not whole node) - you can look at its injection in the MCO manifest itself. When the MCO starts it reads the env and prints it, it's also later used in the code. The version is set by the release payload builder.

Look here https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/1551/pull-ci-openshift-machine-config-operator-master-e2e-gcp-op/1497/artifacts/e2e-gcp-op/pods/openshift-machine-config-operator_machine-config-operator-5cc998d49d-hztvc_machine-config-operator.log

I0310 07:23:13.168998       1 start.go:46] Version: 0.0.1-2020-03-10-070742 (Raw: machine-config-daemon-4.5.0-202003100116-2-g3ac4b8ff-dirty, Hash: 3ac4b8ff765a46930ef210cf977531371a803819)

it now prints the version (and it does so at bootstrap as well).

/retest

[runcom]

/retest

[yuqi-zhang]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [runcom,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@runcom: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1551. Bugzilla bug 1811898 has been moved to the MODIFIED state.

In response to this:

Bug 1811898: cmd/machine-config-operator: log RELEASE_VERSION when starting up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.