[baremetal] Add support for reading API LB backends from KUBE-API #1574
Conversation
openshift-ci-robot
added
the
approved
| @@ -19,7 +19,10 @@ contents: | |||
| path: "/etc/kubernetes/static-pod-resources/haproxy" | |||
| - name: kubeconfig | |||
| hostPath: | |||
| path: "/etc/kubernetes/kubeconfig" | |||
| path: "/etc/kubernetes" | |||
There was a problem hiding this comment.
Why do we do this path change?
There was a problem hiding this comment.
@celebdor
Hmm, I think that @bcrochet reported in keepalived-unicast PR [1] that he needed to mount /etc/kubernetes instead of /etc/kubernetes/kubeconfig - so I did the same also here.
I'll recheck this PR this time with /etc/kubernetes/kubeconfig, if it's works - I'll update the PR.
[1]
https://github.com/openshift/machine-config-operator/pull/1504/files#diff-c2a4c0270459a7bea650ed87b237329eR22
There was a problem hiding this comment.
@celebdor - It appears that we don't need the kubeconfig anymore here, just the '/var/lib/kubelet' , so, I just deleted it and added the 'var/lib/kubelet'
This PR updates HAProxy static pod manifest to enable reading API LB backend details from Kubernetes instead of _etcd-server-ssl._tcp SRV.
yboaron
force-pushed
the
tst_haproxy_kube
branch
from
9067843
to
908815b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, bcrochet, yboaron, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This PR updates OpenStack and Ovirt HAProxy static pod manifest to enable reading API LB backend details from Kubernetes instead of _etcd-server-ssl._tcp SRV. Originated from openshift#1574
This PR updates HAProxy static pod manifest to enable reading API LB backend details
from Kubernetes instead of _etcd-server-ssl._tcp SRV.
- What I did
- How to verify it
- Description for the changelog