Bug 1817594: [release-4.4] Nodeip retry on failure #1616
Conversation
It is possible for NM-wait-online to let our node ip configuration service go through before the control plane IP Address and/or Route is configured. In such cases it would be great to have the systemd service be able to retry on failure. Unfortunately, the current version of RHCOS does not have a new enough systemd version, so we implement the retry mechanism in the script itself. Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
In my deployments I am seeing routes that include fields the non_virtual_ip script can't handle. This causes it to fail and anything relying on it to function incorrectly. This change adds a **kwargs parameter to the class constructor so it will take arbitrary params that we will then ignore. It also filters out \ characters from the routes because I'm seeing that as well and we don't want to try to parse it. The \ appears in multi-line routes that can't be handled correctly by the existing structure of the class because they have multiple 'via' values and the class can only handle one per route. However, this is happening only on the default route in my case, which we ignore anyway, and this script is being replaced by a Go implementation in the near future so I don't think it's worth rewriting it to handle multi-line routes.
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1819484, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/retitle Bug 1817594: Nodeip retry on failure |
openshift-ci-robot
changed the title
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1817594, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
runcom
changed the title
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@sinnykumari: This pull request references Bugzilla bug 1817594, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/lgtm |
|
/bugzilla refresh |
|
@celebdor: This pull request references Bugzilla bug 1817594, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I manage to verify the fix on dev-scripts with openshift4.4
And checking the logs nodeip-configuration service in master-2 node, we can see that retry was activated .
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, runcom, sinnykumari, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@kikisdeliveryservice: This pull request references Bugzilla bug 1817594, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ashcrow this is ready for cherrypick |
ashcrow
added
the
cherry-pick-approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1616. Bugzilla bug 1817594 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #1601
/assign celebdor