Bug 1821005: oVirt, fix disable tx checksum offload for workers #1621
Conversation
|
/cc rgolangh |
|
/test e2e-ovirt |
templates/worker/00-worker/ovirt/files/ovirt-disable-tx-checksum-offload.yaml
Outdated
Show resolved
Hide resolved
On PR [1] we added a workaround for Bug [2], this fails when the worker starts for the first time since openshift-sdn is created only when the sdn pod is starting. Instead we will disable by default leave as is only when running with OVNkubernetes [1] On PR openshift#1606, [2] https://bugzilla.redhat.com/show_bug.cgi?id=1794714 Signed-off-by: Gal Zaidman <gzaidman@redhat.com>
Gal-Zaidman
force-pushed
the
diasable-checksum
branch
from
1aaa34f
to
db6ef51
Compare
|
/test e2e-ovirt |
1 similar comment
|
/test e2e-ovirt |
This patch adds the workaround suggested on [1] to make nodeport work, instead of ethtool we use NM to apply the fix for each connction before it is up. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714 Brings the following ovirt fixes to openstack platform: - openshift#1606 - openshift#1621
|
/retest e2e-ovirt |
|
/test e2e-ovirt |
|
/assign @kikisdeliveryservice |
|
Tested manually by logging into the machines and checking the connection |
|
/lgtm |
This patch adds the workaround suggested on [1] to make nodeport work, instead of ethtool we use NM to apply the fix for each connction before it is up. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714 Brings the following ovirt fixes to openstack platform: - openshift#1606 - openshift#1621
|
/retitle Bug 1821005: oVirt, fix disable tx checksum offload for workers |
openshift-ci-robot
changed the title
|
@Gal-Zaidman: This pull request references Bugzilla bug 1821005, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
|
@Gal-Zaidman: This pull request references Bugzilla bug 1821005, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@rgolangh: This pull request references Bugzilla bug 1821005, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@rgolangh: This pull request references Bugzilla bug 1821005, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/test e2e-aws |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gal-Zaidman, rgolangh, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/skip e2e-aws-scaleup-rhel7 |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@Gal-Zaidman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
@Gal-Zaidman: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1621, openshift/machine-config-operator#1606. Bugzilla bug 1821005 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This patch adds the workaround suggested on [1] to make nodeport work, instead of ethtool we use NM to apply the fix for each connction before it is up. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714 Brings the following ovirt fixes to openstack platform: - openshift#1606 - openshift#1621
On PR [1] we added a workaround for Bug [2], this
fails when the worker starts for the first time since openshift-sdn
is created only when the sdn pod is starting.
Instead we will disable by default and enable tx-checksum offload
only when running with OVNkubernetes
[1] On PR #1606,
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1794714
Signed-off-by: Gal Zaidman gzaidman@redhat.com
- What I did
- How to verify it
- Description for the changelog