Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1823677:etcdquorumguard_deployment: pass NSS_SDB_USE_CACHE=no to curl #1648

Merged

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Apr 14, 2020

- What I did
Updated the script created by etcd quroum guard deployment to run curl with NSS_SDB_USE_CACHE=no

- How to verify it
Observe etcd-quorum-guard memory consumption

- Description for the changelog
Fixed an issue in 4.5/4.4 which caused memory consumption of readyness probes in etcd-quorum-guard

Initial fix: #705, regression occurred in #1552
Ref: okd-project/okd#146

Ensure `curl` command has NSS_SDB_USE_CACHE env var set
@vrutkovs
Copy link
Member Author

/cherry-pick fcos

@openshift-cherrypick-robot

@vrutkovs: once the present PR merges, I will cherry-pick it on top of fcos in a new PR and assign it to you.

In response to this:

/cherry-pick fcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs changed the title etcdquorumguard_deployment: pass NSS_SDB_USE_CACHE=no to curl Bug 1823677:etcdquorumguard_deployment: pass NSS_SDB_USE_CACHE=no to curl Apr 14, 2020
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: This pull request references Bugzilla bug 1823677, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1823677:etcdquorumguard_deployment: pass NSS_SDB_USE_CACHE=no to curl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 14, 2020
@vrutkovs
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 14, 2020
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: This pull request references Bugzilla bug 1823677, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 14, 2020
@hexfusion
Copy link
Contributor

/lgtm

thanks @vrutkovs

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2020
@hexfusion
Copy link
Contributor

/test e2e-gcp-upgrade

@LorbusChris
Copy link
Member

/test e2e-gcp-op

@runcom
Copy link
Member

runcom commented Apr 14, 2020

/approve
/skip

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, runcom, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 14, 2020

@vrutkovs: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 7c3b181 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2fd0f40 into openshift:master Apr 15, 2020
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1648. Bugzilla bug 1823677 has been moved to the MODIFIED state.

In response to this:

Bug 1823677:etcdquorumguard_deployment: pass NSS_SDB_USE_CACHE=no to curl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@vrutkovs: new pull request created: #1653

In response to this:

/cherry-pick fcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Member Author

/cherry-pick release-4.4

@openshift-cherrypick-robot

@vrutkovs: #1648 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	install/0000_80_machine-config-operator_07_etcdquorumguard_deployment.yaml
Falling back to patching base and 3-way merge...
Auto-merging install/0000_80_machine-config-operator_07_etcdquorumguard_deployment.yaml
CONFLICT (content): Merge conflict in install/0000_80_machine-config-operator_07_etcdquorumguard_deployment.yaml
Patch failed at 0001 etcdquorumguard_deployment: pass NSS_SDB_USE_CACHE=no to curl

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants