Bug 1820507: Add new crio.conf field to the template #1664
Conversation
Add the default_env field to the crio.conf template that is laid down by the MCO Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
@umohnani8: This pull request references Bugzilla bug 1820507, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, rphillips, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-scaleup-rhel7 |
There was a problem hiding this comment.
- I can’t see any references to
default_envin the CRI-O repo. (??) - The change is extremely non-obvious, so at the very least one of the PR/commit message, and ideally directly the template contents, should contain or link to a good explanation. I don’t know what that is, maybe https://bugzilla.redhat.com/show_bug.cgi?id=1779325 ? I don’t know the full story.
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-gcp-upgrade |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@umohnani8: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1664. Bugzilla bug 1820507 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #1820507 (https://bugzilla.redhat.com/show_bug.cgi?id=1820507)
Signed-off-by: Urvashi Mohnani umohnani@redhat.com
- What I did
Add the default_env field to the crio.conf template
that is laid down by the MCO
- How to verify it
- Description for the changelog
Add default_env filed to the crio.conf template