Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.3] Bug 1822269: Add new crio.conf field to the template #1668

Merged
merged 1 commit into from May 2, 2020
Merged

[release-4.3] Bug 1822269: Add new crio.conf field to the template #1668

merged 1 commit into from May 2, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1663

/assign umohnani8

@umohnani8
Add new crio.conf field to the template
0dff4e5 
Add the default_env field to the crio.conf template
that is laid down by the MCO

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 21, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1822268, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected dependent Bugzilla bug 1820507 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1820507 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] [release 4.4] Bug 1822268: Add new crio.conf field to the template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 21, 2020
@mrunalp
Copy link
Member

mrunalp commented Apr 21, 2020

/retest

2 similar comments
@umohnani8
Copy link
Contributor

/retest

@umohnani8
Copy link
Contributor

/retest

@kikisdeliveryservice kikisdeliveryservice changed the title [release-4.3] [release 4.4] Bug 1822268: Add new crio.conf field to the template [release-4.3] Bug 1822268: Add new crio.conf field to the template Apr 23, 2020
@kikisdeliveryservice
Copy link
Contributor

This needs a 4.3 BZ

kikisdeliveryservice
kikisdeliveryservice approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was cherrypicked with the old 4.4 BZ as name, it needs a 4.3 BZ.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020
@umohnani8
Copy link
Contributor

Fixes #1822269 (https://bugzilla.redhat.com/show_bug.cgi?id=1822269)

@kikisdeliveryservice kikisdeliveryservice changed the title [release-4.3] Bug 1822268: Add new crio.conf field to the template [release-4.3] Bug 1822269: Add new crio.conf field to the template Apr 23, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1822269, which is invalid:

  • expected dependent Bugzilla bug 1819906 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1820507 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1819906 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead
  • expected dependent Bugzilla bug 1820507 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1822269: Add new crio.conf field to the template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: This pull request references Bugzilla bug 1822269, which is invalid:

  • expected dependent Bugzilla bug 1819906 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1820507 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1819906 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead
  • expected dependent Bugzilla bug 1820507 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umohnani8
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@umohnani8: This pull request references Bugzilla bug 1822269, which is invalid:

  • expected dependent Bugzilla bug 1820507 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1820507 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umohnani8
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 24, 2020
@openshift-ci-robot
Copy link
Contributor

@umohnani8: This pull request references Bugzilla bug 1822269, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1822268 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1822268 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 24, 2020
@kikisdeliveryservice
Copy link
Contributor

/approve

@kikisdeliveryservice
Copy link
Contributor

Bumping: this needs a LGTM to get cherrypicked.

@rphillips
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, openshift-cherrypick-robot, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp mrunalp added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Apr 27, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed bugzilla/urgent labels Apr 29, 2020
@sdodson
Copy link
Member

sdodson commented May 1, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@sdodson: This pull request references Bugzilla bug 1822269, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1822268 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1822268 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 1, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 860382c into openshift:release-4.3 May 2, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1668. Bugzilla bug 1822269 has been moved to the MODIFIED state.

In response to this:

[release-4.3] Bug 1822269: Add new crio.conf field to the template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

This PR was merged in the time period when ci-operator was mistakenly reporting failed tests as passing.

If this repository has ci-operator jobs, please inspect their test results even if passing, and consider the need for fixing or even reverting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@mtrmac mtrmac Awaiting requested review from mtrmac

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@rphillips rphillips

@umohnani8 umohnani8

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @openshift-ci-robot @mrunalp @umohnani8 @kikisdeliveryservice @rphillips @sdodson @openshift-bot @openshift-merge-robot