New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1802534: gcp-routes: move to MCO, implement downfile, tweak timing #1670
Bug 1802534: gcp-routes: move to MCO, implement downfile, tweak timing #1670
Conversation
cc @sttts |
PR adding downfile support to gcp-routes.sh: https://gitlab.cee.redhat.com/coreos/redhat-coreos/merge_requests/899 |
@squeed: This pull request references Bugzilla bug 1802534, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
templates/master/00-master/gcp/files/etc-kubernetes-manifests-gcp-routes-controller.yaml
Show resolved
Hide resolved
/hold |
/cherry-pick fcos |
@LorbusChris: once the present PR merges, I will cherry-pick it on top of fcos in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Seems the unit test scaffolding is out-of-date, so this is not going to pass unit tests. Investigating. |
/test e2e-gcp-op |
seeing: |
Nuts. Investigating. |
Those error messages are red herrings; the node maintained access to the internal api server at that time. I suspect they're just from masters rebooting. Continuing the investigation. |
Okay, this is weird: tests are failing because one of the worker nodes failed to start the MCD after a reboot - because CRIO won't create the sandbox.
This definitely isn't caused by my change - mine only touches the master nodes. But it's not good. I wonder if the problem lies with kubelet, crio, or libpod? |
Known (and very scary) bug: 1785399 |
Updated, fixed unit test scaffolding. This job is pretty prone to triggering the crio leak, so it might be a while before this goes green. AFAICT it's not a bug in the PR. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
This seems to be a horrid test issue. |
/test e2e-aws |
1 similar comment
/test e2e-aws |
/hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
It looks like whatever the problem in https://bugzilla.redhat.com/show_bug.cgi?id=1828606 is biting us. Given that this doesn't touch aws at all, would this be a candidate for an /override ? |
/retest Please review the full test history for this PR and help us cut down flakes. |
@squeed: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1670. Bugzilla bug 1802534 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@LorbusChris: new pull request created: #1741 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@sttts: new pull request created: #1780 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Move gcp-routes to the MCO, call it openshift-gcp-routes. Also, improve the behavior significantly: