Bug 1805908: Add template for recycler pod #1687
Conversation
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
bertinatto
force-pushed
the
recycler-pod
branch
from
52f998d
to
dbb7714
Compare
bertinatto
force-pushed
the
recycler-pod
branch
from
dbb7714
to
43dcb59
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@bertinatto we need a PR in https://github.com/openshift/cluster-kube-controller-manager-operator/ for updating arguments to controller-manger as well? |
Yes, there's a link up above for that PR |
kikisdeliveryservice
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@bertinatto: This pull request references Bugzilla bug 1805908, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
I'll leave to storage or whoever is in charge of this to lgtm, approving meanwhile as it seems right /approve |
openshift-ci-robot
added
the
approved
|
/skip |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@bertinatto: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1687. Bugzilla bug 1805908 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bertinatto: cannot checkout 4.5: error checking out 4.5: exit status 1. output: error: pathspec '4.5' did not match any file(s) known to git In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@bertinatto: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.5 and openshift-cherrypick-robot:cherry-pick-1687-to-release-4.5"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@bertinatto: new pull request created: #2004 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- What I did
Added template for recycler pod.
- How to verify it
This should create a new file in
/etc/kubernetes/manifests/recycler-pod.yaml.CC @openshift/storage