Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update openshift/api for IPv6DualStackNoUpgrade featureset #1709

Merged
merged 2 commits into from Jun 25, 2020
Merged

update openshift/api for IPv6DualStackNoUpgrade featureset #1709

merged 2 commits into from Jun 25, 2020

Conversation

danwinship
Copy link
Contributor

Pulls in openshift/api#638 so MCO will recognize featureSet: IPv6DualStackNoUpgrade

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2020
@danwinship danwinship changed the title WIP update openshift/api for IPv6DualStackNoUpgrade featureset update openshift/api for IPv6DualStackNoUpgrade featureset Jun 10, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2020
@danwinship
Copy link
Contributor Author

updated with real vendor update. I wasn't totally sure how I was supposed to do this, but I ended up just editing the replace line in go.mod and then running make go-deps.

@danwinship
templates: update for newly-added default feature gate from openshift…
b5b5ad1 
…/api bump

(The feature gate has no effect on kubelet but we add it anyway so
this is needed to make TestFeatureGateDrift pass.)
@danwinship
Copy link
Contributor Author

/retest
ping. the other operators that needed similar patches have all been updated now so this is the last one needed

@danwinship
Copy link
Contributor Author

/assign @cgwalters @runcom
ping again...

@ashcrow
Copy link
Member

ashcrow commented Jun 24, 2020

Adding @sinnykumari and @yuqi-zhang to review.

@cgwalters
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@yuqi-zhang
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, danwinship, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 667c808 into openshift:master Jun 25, 2020
@danwinship danwinship deleted the dual-stack-featureset branch June 25, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@runcom runcom Awaiting requested review from runcom

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

@cgwalters cgwalters

@runcom runcom

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@danwinship @ashcrow @cgwalters @yuqi-zhang @openshift-ci-robot @openshift-bot @runcom @openshift-merge-robot