Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1784201: lib/resourcemerge: set AdditionalTrustBundle #1714

Merged
merged 1 commit into from May 6, 2020

Conversation

runcom
Copy link
Member

@runcom runcom commented May 5, 2020

Proxy day2 wasn't working because the MCO wasn't rolling the additionalTrustBundle to nodes. Now it does and day2 proxy is deployed.

Signed-off-by: Antonio Murdaca runcom@linux.com

Signed-off-by: Antonio Murdaca <runcom@linux.com>
@runcom runcom added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2020
@runcom runcom changed the title WIP: lib/resourcemerge: gosh, set AdditionalTrustedBundle Bug 1784201: lib/resourcemerge: set AdditionalTrustBundle May 5, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2020
@runcom runcom removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels May 5, 2020
@openshift-ci-robot
Copy link
Contributor

@runcom: This pull request references Bugzilla bug 1784201, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1784201: lib/resourcemerge: set AdditionalTrustBundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@runcom: This pull request references Bugzilla bug 1784201, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1784201: lib/resourcemerge: set AdditionalTrustBundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 5, 2020
@runcom
Copy link
Member Author

runcom commented May 5, 2020

cc @danehans

@runcom
Copy link
Member Author

runcom commented May 5, 2020

Tested on a cluster, working as expected now, kube-controller-manager is stuck at Available=True,Progressing=True,Degraded=True which looks totally unrelated to this as all other operators are doing just fine after the proxy rollout. This patch might have exposed a bug there (or it's just slow rn) or since my test uses 4.5.latest something else is going on. Let's see if tests pass here also.

@runcom
Copy link
Member Author

runcom commented May 5, 2020

/test e2e-proxy

@openshift-ci-robot
Copy link
Contributor

@runcom: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-scaleup-rhel7
  • /test e2e-gcp-op
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-openstack
  • /test e2e-ovirt
  • /test e2e-vsphere
  • /test images
  • /test unit
  • /test verify

Use /test all to run all jobs.

In response to this:

/test e2e-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom
Copy link
Member Author

runcom commented May 5, 2020

@runcom: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

right.... we need to enable that perhaps - this change is so tiny it's clear it's not affecting that tho 🤷‍♂️

@runcom
Copy link
Member Author

runcom commented May 5, 2020

/skip

@danehans
Copy link

danehans commented May 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@runcom
Copy link
Member Author

runcom commented May 6, 2020

/skip
/refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 6, 2020

@runcom: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 a52b1f6 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-metal-ipi a52b1f6 link /test e2e-metal-ipi

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@runcom
Copy link
Member Author

runcom commented May 6, 2020

/skip

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fb6d38d into openshift:master May 6, 2020
@openshift-ci-robot
Copy link
Contributor

@runcom: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1714. Bugzilla bug 1784201 has been moved to the MODIFIED state.

In response to this:

Bug 1784201: lib/resourcemerge: set AdditionalTrustBundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom runcom deleted the day2-proxy-take2 branch May 6, 2020 08:29
@runcom
Copy link
Member Author

runcom commented Jun 18, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot

@runcom: new pull request created: #1843

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants