New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1784201: lib/resourcemerge: set AdditionalTrustBundle #1714
Bug 1784201: lib/resourcemerge: set AdditionalTrustBundle #1714
Conversation
Signed-off-by: Antonio Murdaca <runcom@linux.com>
@runcom: This pull request references Bugzilla bug 1784201, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@runcom: This pull request references Bugzilla bug 1784201, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @danehans |
Tested on a cluster, working as expected now, |
/test e2e-proxy |
@runcom: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
right.... we need to enable that perhaps - this change is so tiny it's clear it's not affecting that tho 🤷♂️ |
/skip |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
/skip |
@runcom: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/skip |
/retest Please review the full test history for this PR and help us cut down flakes. |
@runcom: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1714. Bugzilla bug 1784201 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@runcom: new pull request created: #1843 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Proxy day2 wasn't working because the MCO wasn't rolling the additionalTrustBundle to nodes. Now it does and day2 proxy is deployed.
Signed-off-by: Antonio Murdaca runcom@linux.com