Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1817430: Parse the kubelet.conf data after an update #1725

Merged
merged 1 commit into from May 14, 2020

Conversation

umohnani8
Copy link
Contributor

@umohnani8 umohnani8 commented May 11, 2020

Fixes #1817430 (https://bugzilla.redhat.com/show_bug.cgi?id=1817430)

Signed-off-by: Urvashi Mohnani umohnani@redhat.com

- What I did
After a kubeletconfig CR rolls out updates to the
kubelet.conf, we want to parse the contents so that
it is printed out in a pretty format.

- How to verify it
Create a kubeletconfig CR and check the nodes to ensure that /etc/kubernetes/kubelet.conf is formatted correctly with the tabs and all

- Description for the changelog
Parse the contents of the kubelet.conf after a CR update to ensure it is pretty printed

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 11, 2020
@openshift-ci-robot
Copy link
Contributor

@umohnani8: This pull request references Bugzilla bug 1817430, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1817430: Fix the kubelet.conf encoding to use YAML

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umohnani8
Copy link
Contributor Author

@rphillips PTAL

@openshift-ci-robot
Copy link
Contributor

@umohnani8: This pull request references Bugzilla bug 1817430, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1817430: Fix the kubelet.conf encoding to use YAML

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umohnani8 umohnani8 changed the title Bug 1817430: Fix the kubelet.conf encoding to use YAML Bug 1817430: Parse the kubelet.conf data after an update May 13, 2020
After a kubeletconfig CR rolls out updates to the
kubelet.conf, we want to parse the contents so that
it is printed out in a pretty format.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
@rphillips
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2020
@rphillips
Copy link
Contributor

/assign @kikisdeliveryservice

ptal

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, rphillips, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@umohnani8
Copy link
Contributor Author

/test e2e-gcp-op

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 65558a5 into openshift:master May 14, 2020
@openshift-ci-robot
Copy link
Contributor

@umohnani8: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1725. Bugzilla bug 1817430 has been moved to the MODIFIED state.

In response to this:

Bug 1817430: Parse the kubelet.conf data after an update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umohnani8
Copy link
Contributor Author

/cherry-pick release-4.4

@openshift-cherrypick-robot

@umohnani8: new pull request created: #1734

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants