New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1817430: Parse the kubelet.conf data after an update #1725
Conversation
@umohnani8: This pull request references Bugzilla bug 1817430, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rphillips PTAL |
5092ae8
to
cfcb0d0
Compare
@umohnani8: This pull request references Bugzilla bug 1817430, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
After a kubeletconfig CR rolls out updates to the kubelet.conf, we want to parse the contents so that it is printed out in a pretty format. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
/lgtm |
/assign @kikisdeliveryservice ptal |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, rphillips, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test e2e-gcp-op |
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@umohnani8: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1725. Bugzilla bug 1817430 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@umohnani8: new pull request created: #1734 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #1817430 (https://bugzilla.redhat.com/show_bug.cgi?id=1817430)
Signed-off-by: Urvashi Mohnani umohnani@redhat.com
- What I did
After a kubeletconfig CR rolls out updates to the
kubelet.conf, we want to parse the contents so that
it is printed out in a pretty format.
- How to verify it
Create a kubeletconfig CR and check the nodes to ensure that /etc/kubernetes/kubelet.conf is formatted correctly with the tabs and all
- Description for the changelog
Parse the contents of the kubelet.conf after a CR update to ensure it is pretty printed