New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 1834925: vsphere: check if .Infra.Status and .Infra.Status.PlatformStatus is nil #1728

Merged

openshift-merge-robot merged 1 commit into openshift:master from jcpowermac:BZ1834194

May 14, 2020

Contributor

jcpowermac commented May 12, 2020

Update the vsphere templates to check if .Infra.Status and .Infra.Status.PlatformStatus is nil.


          vsphere: check if .Infra.Status and .Infra.Status.PlatformStatus is nil

5dbb30e

openshift-ci-robot added the do-not-merge/work-in-progress label

Contributor Author

jcpowermac commented May 12, 2020

/test e2e-vsphere
/test e2e-vsphere-upi

openshift-ci-robot requested review from kikisdeliveryservice and mrunalp

May 12, 2020 14:48

Contributor

yuqi-zhang commented May 12, 2020

/test e2e-vsphere

jcpowermac changed the title ~~[wip] vsphere: check if .Infra.Status and .Infra.Status.PlatformStatus is nil~~ bug 1834925: vsphere: check if .Infra.Status and .Infra.Status.PlatformStatus is nil

openshift-ci-robot added bugzilla/severity-medium bugzilla/valid-bug and removed do-not-merge/work-in-progress labels

Contributor

openshift-ci-robot commented May 12, 2020

@jcpowermac: This pull request references Bugzilla bug 1834925, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

bug 1834925: vsphere: check if .Infra.Status and .Infra.Status.PlatformStatus is nil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor Author

jcpowermac commented May 12, 2020

cc: @patrickdillon @mtnbikenc

Contributor

patrickdillon commented May 12, 2020

fun with pointers
/lgtm

openshift-ci-robot assigned patrickdillon

openshift-ci-robot added the lgtm label

yuqi-zhang approved these changes

View reviewed changes

Contributor

openshift-ci-robot commented May 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, patrickdillon, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the approved label

Contributor

openshift-bot commented May 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments

Contributor

openshift-bot commented May 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

kikisdeliveryservice commented May 12, 2020

@jcpowermac can you PTAL at the e2e-vsphere errors? we are already aware of an issue existing in gcp-op jobs, but vsphere jobs looks very red? https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/job-history/origin-ci-test/pr-logs/directory/pull-ci-openshift-machine-config-operator-master-e2e-vsphere

Contributor

openshift-bot commented May 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments

Contributor

openshift-bot commented May 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

20 similar comments

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented May 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-ci-robot commented May 14, 2020

@jcpowermac: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere	`5dbb30e`	link	`/test e2e-vsphere`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot merged commit 010ac67 into openshift:master

Contributor

openshift-ci-robot commented May 14, 2020

@jcpowermac: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1728. Bugzilla bug 1834925 has been moved to the MODIFIED state.

In response to this:

bug 1834925: vsphere: check if .Infra.Status and .Infra.Status.PlatformStatus is nil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor Author

jcpowermac commented May 15, 2020

/cherry-pick release-4.4

openshift-cherrypick-robot commented May 15, 2020

@jcpowermac: #1728 failed to apply on top of branch "release-4.4":

Using index info to reconstruct a base tree...
A	templates/common/vsphere/files/NetworkManager-mdns-hostname.yaml
A	templates/common/vsphere/files/etc-systemd-system-crio-stream-address.conf.yaml
M	templates/common/vsphere/files/vsphere-NetworkManager-kni-conf.yaml
M	templates/common/vsphere/files/vsphere-coredns-corefile.yaml
M	templates/common/vsphere/files/vsphere-coredns.yaml
A	templates/common/vsphere/files/vsphere-hostname.yaml
M	templates/common/vsphere/files/vsphere-keepalived.yaml
M	templates/common/vsphere/files/vsphere-mdns-publisher.yaml
A	templates/master/00-master/vsphere/files/NetworkManager-resolv-prepender.yaml
M	templates/master/00-master/vsphere/files/vsphere-haproxy-haproxy.yaml
M	templates/master/00-master/vsphere/files/vsphere-haproxy.yaml
M	templates/master/00-master/vsphere/files/vsphere-keepalived-keepalived.yaml
M	templates/master/00-master/vsphere/files/vsphere-mdns-config.yaml
A	templates/master/01-master-kubelet/vsphere/units/kubelet.yaml
A	templates/worker/00-worker/vsphere/files/NetworkManager-resolv-prepender.yaml
M	templates/worker/00-worker/vsphere/files/vsphere-keepalived-keepalived.yaml
A	templates/worker/01-worker-kubelet/vsphere/units/kubelet.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/worker/01-worker-kubelet/baremetal/units/kubelet.yaml
CONFLICT (content): Merge conflict in templates/worker/01-worker-kubelet/baremetal/units/kubelet.yaml
Auto-merging templates/worker/00-worker/vsphere/files/vsphere-keepalived-keepalived.yaml
Auto-merging templates/worker/00-worker/baremetal/files/NetworkManager-resolv-prepender.yaml
CONFLICT (content): Merge conflict in templates/worker/00-worker/baremetal/files/NetworkManager-resolv-prepender.yaml
Auto-merging templates/master/01-master-kubelet/_base/units/kubelet.yaml
CONFLICT (content): Merge conflict in templates/master/01-master-kubelet/_base/units/kubelet.yaml
Auto-merging templates/master/00-master/vsphere/files/vsphere-mdns-config.yaml
Auto-merging templates/master/00-master/vsphere/files/vsphere-keepalived-keepalived.yaml
Auto-merging templates/master/00-master/vsphere/files/vsphere-haproxy.yaml
Auto-merging templates/master/00-master/vsphere/files/vsphere-haproxy-haproxy.yaml
Auto-merging templates/master/00-master/baremetal/files/NetworkManager-resolv-prepender.yaml
CONFLICT (content): Merge conflict in templates/master/00-master/baremetal/files/NetworkManager-resolv-prepender.yaml
Auto-merging templates/common/vsphere/files/vsphere-mdns-publisher.yaml
Auto-merging templates/common/vsphere/files/vsphere-keepalived.yaml
CONFLICT (modify/delete): templates/common/vsphere/files/vsphere-hostname.yaml deleted in HEAD and modified in vsphere: check if .Infra.Status and .Infra.Status.PlatformStatus is nil. Version vsphere: check if .Infra.Status and .Infra.Status.PlatformStatus is nil of templates/common/vsphere/files/vsphere-hostname.yaml left in tree.
Auto-merging templates/common/vsphere/files/vsphere-coredns.yaml
Auto-merging templates/common/vsphere/files/vsphere-coredns-corefile.yaml
Auto-merging templates/common/vsphere/files/vsphere-NetworkManager-kni-conf.yaml
Auto-merging templates/common/baremetal/files/etc-systemd-system-crio-stream-address.conf.yaml
CONFLICT (content): Merge conflict in templates/common/baremetal/files/etc-systemd-system-crio-stream-address.conf.yaml
Auto-merging templates/common/baremetal/files/NetworkManager-mdns-hostname.yaml
CONFLICT (content): Merge conflict in templates/common/baremetal/files/NetworkManager-mdns-hostname.yaml
error: Failed to merge in the changes.
Patch failed at 0001 vsphere: check if .Infra.Status and .Infra.Status.PlatformStatus is nil

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac added a commit to jcpowermac/machine-config-operator that referenced this pull request


          [release-4.4] Bug 1834194: vsphere: check if .Infra.Status and .Infra…

43702eb

….Status.PlatformStatus is nil

Cherry-pick: openshift#1728

jcpowermac mentioned this pull request

Bug 1834194: vsphere: check if .Infra.Status and .Infra.Status.PlatformStatus is nil #1735

Merged

openshift-ci-robot mentioned this pull request

[release-4.5] Bug 1834925: vsphere templates check if Infra is nil #1783

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment