Bug 1841581: Ensure resolv.conf is in place in prepender before running podman #1765
Conversation
|
|
||
| # Ensure resolv.conf exists before we try to run podman | ||
| cp /var/run/NetworkManager/resolv.conf /etc/resolv.conf | ||
|
|
There was a problem hiding this comment.
It's probably safer to do this in the case I think, so it only copies on a valid $STATUS?
We can then also remove the else "Couldn't find a Virtual IP" part
stbenjam
changed the title
openshift-ci-robot
added
the
bugzilla/severity-unspecified
|
@stbenjam: This pull request references Bugzilla bug 1841581, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/severity-urgent
|
@stbenjam: This pull request references Bugzilla bug 1841581, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Since we now have `set -e`, when podman fails the whole script fails, and we end up with no resolv.conf at all. Previously, the podman failed but we fellthrough to where we copy the file to /etc/resolv.conf, and on the second run it succeeds.
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, cgwalters, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
lgtm, thanks! |
|
@stbenjam: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@stbenjam: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1765. Bugzilla bug 1841581 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This aligned OpenStack and vSphere platforms with with the BM one after openshift#1763 and openshift#1765.
This aligned OpenStack and vSphere platforms with with the BM one after openshift#1763 and openshift#1765.
Manual backport of openshift#1773 to release-4.5 because of merge conflict. We can't share the prepender script between control plane and compute nodes in OpenStack due to dependency on the DNS VIP. This basically boils down to porting openshift#1765 to the openstack worker prepender script that was forgotten in the initial commit. VShpere counterpart doesn't run podman and hence doesn't need the patch.
Manual backport of openshift#1773 to release-4.5 because of merge conflict. We can't share the prepender script between control plane and compute nodes in OpenStack due to dependency on the DNS VIP. This basically boils down to porting openshift#1765 to the openstack worker prepender script that was forgotten in the initial commit. VShpere counterpart doesn't run podman and hence doesn't need the patch.
Since we now have
set -e, when podman fails the whole script fails,and we end up with no resolv.conf at all. Previously, the podman failed
but we fellthrough to where we copy the file to /etc/resolv.conf, and on
the second run it succeeds.