New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM: Migrate internals to Ignition spec v3.1 #1778
Conversation
5a6be29
to
8c91e93
Compare
cebad41
to
1a52c9b
Compare
/cc @yuqi-zhang @runcom @ashcrow |
I'm working on the last bit for this, there is a bunch of de-duplication and extra translating/error handling that would be needed. |
So this is a first pass WIP PR: #1873 that handles the upgrade path as well. (The rendering is roughly the same as what's in this PR, I started working on it without realizing this one existed) |
a0326c4
to
06a32d7
Compare
/retest |
1 similar comment
/retest |
eaa8026
to
5e96c24
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LorbusChris The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR will be superseded by #1873. |
afc2689
to
61aea41
Compare
/retest |
/test e2e-gcp-upgrade |
61aea41
to
39640ad
Compare
/retest |
39640ad
to
ab10ecc
Compare
This migrates all internal on-disk state representation over to Ignition config spec v3.1. Compatibilty with older boot images is retained: In the MCS, the User Agent on the request is inspected so it can respond with a supported version, translated if needed.
ab10ecc
to
f8b4f4f
Compare
/retest |
1 similar comment
/retest |
@LorbusChris: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
#1873 is on the finishing straight 🎉 |
@LorbusChris: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR was a great reference, thanks! 🎉 |
This migrates all internal on-disk state representation over to
Ignition config spec v3.1.
Compatibilty with older boot images is retained:
In the MCS, the User Agent on the request is inspected so it can
respond with a supported version, translated in needed.
Contains all 3 commits from #1703.
Will be superseded by #1873