Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/operator: collect all needed resources #1779

Merged
merged 1 commit into from Jun 6, 2020

Conversation

runcom
Copy link
Member

@runcom runcom commented Jun 4, 2020

collect everything needed, should be better than openshift/must-gather#157

Signed-off-by: Antonio Murdaca runcom@linux.com

@runcom runcom requested a review from deads2k June 4, 2020 11:49
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2020
@runcom
Copy link
Member Author

runcom commented Jun 4, 2020

/skip

1 similar comment
@runcom
Copy link
Member Author

runcom commented Jun 4, 2020

/skip

@runcom
Copy link
Member Author

runcom commented Jun 4, 2020

Niiice this is working now (on a test cluster):

...
[must-gather-mwthl] OUT cluster-scoped-resources/machineconfiguration.openshift.io/kubeletconfigs/
[must-gather-mwthl] OUT cluster-scoped-resources/machineconfiguration.openshift.io/kubeletconfigs/set-max-pods.yaml
...

Signed-off-by: Antonio Murdaca <runcom@linux.com>
@runcom
Copy link
Member Author

runcom commented Jun 4, 2020

/retest

1 similar comment
@kikisdeliveryservice
Copy link
Contributor

/retest

@enxebre
Copy link
Member

enxebre commented Jun 5, 2020

nice!
/lgtm
/hold
for anyone on mco to unhold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2020
@runcom
Copy link
Member Author

runcom commented Jun 5, 2020

/retest

@sferich888
Copy link

/lgtm

@runcom
Copy link
Member Author

runcom commented Jun 5, 2020

/retest

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, runcom, sferich888, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b51bca1 into openshift:master Jun 6, 2020
@runcom runcom deleted the relatedobjs-fix branch June 8, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants