Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keepalived ingress check's endpoint #1788

Merged
merged 2 commits into from Jun 18, 2020
Merged

Update keepalived ingress check's endpoint #1788

merged 2 commits into from Jun 18, 2020

Conversation

mandre
Copy link
Member

@mandre mandre commented Jun 5, 2020

Based on [1] and [2] we should check for the router's readiness rather than for its liveliness.

This updates the keepalived ingress check query accordingly.

[1] https://github.com/openshift/installer/blob/master/docs/dev/kube-apiserver-health-check.md#load-balancer-health-check-probe
[2] https://github.com/openshift/router/blob/df645b1bb2c4085468845a526ac21cadb54b375d/deploy/router.yaml#L47-L48

@mandre
Update keepalived ingress check's endpoint
8fba273 
Based on [1] and [2] we should check for the router's readiness rather than for its liveliness.

This updates the keepalived ingress check query accordingly.

[1] https://github.com/openshift/installer/blob/master/docs/dev/kube-apiserver-health-check.md#load-balancer-health-check-probe
[2] https://github.com/openshift/router/blob/df645b1bb2c4085468845a526ac21cadb54b375d/deploy/router.yaml#L47-L48
@mandre
Remove useless -k curl flags
f2781fb 
The `-k` flag has no effect for plain http queries, we can remove it.
@mandre
Copy link
Member Author

mandre commented Jun 5, 2020

/test e2e-openstack

@yboaron
Copy link
Contributor

yboaron commented Jun 7, 2020

@mandre ,
I crictl execed into router pod in one of my worker nodes, I curled simultaneously /healthz and healthz/ready while I repeatedly suspend & resume the HAProxy process inside the router container, and it seems to me that both of them fail and recover on the same time.
Do we know what the difference between /healthz and /healthz/ready ?

@yboaron
Copy link
Contributor

yboaron commented Jun 8, 2020

@mandre this is [1] the answer I received from network-edge folks about the difference between /healthz and healthz/ready , so I guess we should use healthz/ready.

[1]
Better to use /healthz/ready. /healthz just means the router has started, but /healthz/ready tells you that it has synched routes and is ready to serve, and /healthz/ready also stops reporting ready when the router starts shutting down, so using /healthz/ready allows the router to drain and terminate gracefully.

@yboaron
Copy link
Contributor

yboaron commented Jun 8, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020
@mandre
Copy link
Member Author

mandre commented Jun 8, 2020

/test e2e-ovirt e2e-vsphere

/cc @rgolangh @patrickdillon

@mandre
Copy link
Member Author

mandre commented Jun 8, 2020

/retest

@kikisdeliveryservice
Copy link
Contributor

/assign @rgolangh @patrickdillon

@rgolangh
Copy link
Contributor

rgolangh commented Jun 9, 2020

lgtm ovirt.
@mandre thanks for ovirt change.

@rgolangh
Copy link
Contributor

rgolangh commented Jun 9, 2020

/test e2e-ovirt

@mandre
Copy link
Member Author

mandre commented Jun 11, 2020

/test e2e-ovirt
/test e2e-vsphere

@pierreprinetti
Copy link
Member

/assign @ashcrow

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, mandre, pierreprinetti, yboaron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4553ca3 into openshift:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

@pierreprinetti pierreprinetti pierreprinetti approved these changes

@Fedosin Fedosin Awaiting requested review from Fedosin

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@rgolangh rgolangh Awaiting requested review from rgolangh

Assignees

@ashcrow ashcrow

@patrickdillon patrickdillon

@rgolangh rgolangh

@yboaron yboaron

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@mandre @yboaron @kikisdeliveryservice @rgolangh @pierreprinetti @openshift-ci-robot @openshift-bot @ashcrow @patrickdillon @openshift-merge-robot