Remove pivot invocations of systemctl reboot #1809
Conversation
openshift-ci-robot
added
the
approved
cgwalters
force-pushed
the
pivot-remove-reboot-code
branch
from
dd6e615
to
56a0683
Compare
|
CI verify is unhappy with |
While chasing https://bugzilla.redhat.com/show_bug.cgi?id=1842906 I thought at one point this code might be invoked and was causing a reboot that shouldn't be happening. That turned out not to be the case. But since nothing uses the `--reboot` or stamp file anymore (we use the `-firstboot`) code, the MCD code is always controlling reboots, delete this code. Code that doesn't exist can't have (potential) bugs.
cgwalters
force-pushed
the
pivot-remove-reboot-code
branch
from
56a0683
to
dd50202
Compare
|
OK finally ran |
|
/retest |
| etcPivotFile = "/etc/pivot/image-pullspec" | ||
| runPivotRebootFile = "/run/pivot/reboot-needed" | ||
| // etcPivotFile is used for 4.1 bootimages and is how the MCD | ||
| // currently communicated with this service. |
There was a problem hiding this comment.
nit: currently communicated would've made my English teacher's stomach turn 😆
Is it currently communicates or previously communicated (previously as in before this PR)?
|
Using this as a victim PR to test openshift/release#9835 |
|
@cgwalters: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hmm, maybe it takes a few minutes to roll out after the Prow configmap updates. Will retry later. |
|
/test cluster-bootimages Edit: seems to be working
|
|
/test cluster-bootimages |
|
Seems like the test is using the wrong |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
While chasing https://bugzilla.redhat.com/show_bug.cgi?id=1842906
I thought at one point this code might be invoked and was causing
a reboot that shouldn't be happening.
That turned out not to be the case. But since nothing uses
the
--rebootor stamp file anymore (we use the-firstboot)code, the MCD code is always controlling reboots, delete this code.
Code that doesn't exist can't have (potential) bugs.