New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FCOS] rebase on release-4.5 #1810
[FCOS] rebase on release-4.5 #1810
Conversation
On ocp 4.6 rchos removed dhclient, so we need to decided to move away from using the DNSVIP. This patch adds NM dispatcher 30-resolv-prepender script to append the nameserver to /etc/resolv.conf. Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
This commits follow [1][2] in removing DNS VIP. Taken from [2]: "Now that etcd does not need DNS for clustering, we no longer need to have a VIP to allow the masters to use the bootstrap coredns until their own coredns instances start. Instead, we can just point them at the local coredns directly and skip the extra complexity." [1] openshift#1569 [2] openshift#1666 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
/cc @LorbusChris Previous branch build failed, so this would trigger it |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, LorbusChris, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/override ci/prow/e2e-aws Previous MCO build didn't complete and OKD 4.5 image is not yet ready, so AWS test won't pass yet |
@vrutkovs: vrutkovs unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold requires installer and machine-os-content built for okd 4.5 first |
/retest |
2 similar comments
/retest |
/retest |
/hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
- What I did
- How to verify it
- Description for the changelog