Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FCOS] rebase on release-4.5 #1810

Merged
merged 3 commits into from Jun 16, 2020

Conversation

vrutkovs
Copy link
Member

- What I did

- How to verify it

- Description for the changelog

Gal-Zaidman added 3 commits June 10, 2020 18:17
On ocp 4.6 rchos removed dhclient, so we need to decided to move away from using the DNSVIP.
This patch adds NM dispatcher 30-resolv-prepender script to append the nameserver to /etc/resolv.conf.

Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
This commits follow [1][2] in removing DNS VIP.

Taken from [2]:
"Now that etcd does not need DNS for clustering, we no longer need to
have a VIP to allow the masters to use the bootstrap coredns until
their own coredns instances start. Instead, we can just point them
at the local coredns directly and skip the extra complexity."

[1] openshift#1569
[2] openshift#1666

Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
@vrutkovs
Copy link
Member Author

/cc @LorbusChris

Previous branch build failed, so this would trigger it

@LorbusChris
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2020
@kikisdeliveryservice
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, LorbusChris, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@kikisdeliveryservice
Copy link
Contributor

/retest

@vrutkovs
Copy link
Member Author

/override ci/prow/e2e-aws

Previous MCO build didn't complete and OKD 4.5 image is not yet ready, so AWS test won't pass yet

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: vrutkovs unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override ci/prow/e2e-aws

Previous MCO build didn't complete and OKD 4.5 image is not yet ready, so AWS test won't pass yet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@vrutkovs
Copy link
Member Author

/hold

requires installer and machine-os-content built for okd 4.5 first

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2020
@vrutkovs
Copy link
Member Author

/retest

2 similar comments
@vrutkovs
Copy link
Member Author

/retest

@vrutkovs
Copy link
Member Author

/retest

@vrutkovs
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 506c447 into openshift:fcos Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants