vsphere nodeip-configuration.service: run node-ip binary from container

[vrutkovs]

- What I did
Replaced python nodeip-finder script with a baremetal's version running in container. This is required on FCOS, which doesn't have python interpreter. Also, this would deduplicate fixes for the same functionality

- How to verify it
vSphere IPI install should pass

- Description for the changelog
Container is used to determine node IP for vSphere

/cc @jcpowermac @patrickdillon

[jcpowermac]

/test e2e-vsphere

[vrutkovs]

openshift/release#9702 would add IPI tests. UPI flow is not affected with this change

[vrutkovs]

/test e2e-vsphere-upi
/test e2e-vsphere

[jcpowermac]

Let's retry IPI - bootstrap didn't complete
/test e2e-vsphere

[jcpowermac]

/test e2e-vsphere

[jcpowermac]

cri-o is unhappy, that is the wrong ip for the node

2: ens192: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    link/ether 00:50:56:b9:5e:70 brd ff:ff:ff:ff:ff:ff
    inet 139.178.94.234/25 brd 139.178.94.255 scope global dynamic noprefixroute ens192

Jun 17 01:55:43 ci-op-jgt1ifhj-6b38f-ss4gt-master-0 crio[2805]: time="2020-06-17 01:55:43.015599455Z" level=fatal msg="Failed to start streaming server: listen tcp 139.178.94.235:10010: bind: cannot assign requested address"
Jun 17 01:55:43 ci-op-jgt1ifhj-6b38f-ss4gt-master-0 systemd[1]: crio.service: Main process exited, code=exited, status=1/FAILURE
Jun 17 01:55:43 ci-op-jgt1ifhj-6b38f-ss4gt-master-0 systemd[1]: crio.service: Failed with result 'exit-code'.

[vrutkovs]

/test e2e-vsphere

[vrutkovs]

Ah, the service runs right after the firstboot, records that IP - and then machine-config-daemon-host.service pivots to new machine-os-content, reboots - and VM gets another IP

[vrutkovs]

/test e2e-vsphere

[vrutkovs]

/test e2e-vsphere

[vrutkovs]

/test e2e-vsphere

[vrutkovs]

/test e2e-vsphere

[vrutkovs]

/test e2e-vsphere

[vrutkovs]

/test e2e-vsphere

[vrutkovs]

Cleaned up the commits and added systemctl daemon-reload so that cri-o would catch new settings if node IP changes between first boot and post-pivot boot

[vrutkovs]

/test e2e-vsphere

[openshift-ci-robot]

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere	74c7e36	link	/test e2e-vsphere
ci/prow/e2e-metal-ipi	74c7e36	link	/test e2e-metal-ipi
ci/prow/e2e-aws-scaleup-rhel7	74c7e36	link	/test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jcpowermac]

/lgtm
Thanks @vrutkovs !

[cgwalters]

/approve

But I would really like to see us rethink this stuff at some point after 4.6 because we have much more powerful abilities since openshift/enhancements#291 particularly for VSphere to control exactly what the node is doing from the first boot.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jcpowermac, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment