Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/old-bootimages: New test #1836

Merged
merged 1 commit into from Jun 18, 2020
Merged

test/old-bootimages: New test #1836

merged 1 commit into from Jun 18, 2020

Conversation

cgwalters
Copy link
Member

Let's validate that old bootimages can join the cluster.
I started this in shell because it seemed simpler, then it got
messy...sorry.

I plan to add this as an optional
/test old-bootimages
Prow job.

@cgwalters
test/old-bootimages: New test
74c02f3 
Let's validate that old bootimages can join the cluster.
I started this in shell because it seemed simpler, then it got
messy...sorry.

I plan to add this as an optional
`/test old-bootimages`
Prow job.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2020
@cgwalters cgwalters mentioned this pull request Jun 17, 2020
Merged
@cgwalters
Copy link
Member Author

/override e2e-aws
/override e2e-metal-ipi
This can't break anything, it's a test that's not running right now; no reason to waste cloud resources on testing it.

@openshift-ci-robot
Copy link
Contributor

@cgwalters: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-aws
  • e2e-metal-ipi

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-scaleup-rhel7
  • ci/prow/e2e-gcp-op
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/e2e-metal-ipi
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • tide

In response to this:

/override e2e-aws
/override e2e-metal-ipi
This can't break anything, it's a test that's not running right now; no reason to waste cloud resources on testing it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member Author

/override ci/prow/e2e-aws
/override ci/prow/e2e-metal-ipi

@openshift-ci-robot
Copy link
Contributor

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/e2e-aws, ci/prow/e2e-metal-ipi

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member Author

I know the code is ugly but it did work; someone mind dropping a /lgtm so I can proceed to add the test job in openshift/release? This won't run by default, just opt in.

@runcom
Copy link
Member

runcom commented Jun 18, 2020

cc @yuqi-zhang
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member Author

e2e-aws is lease exhaustion; there's no reason for us to take up valuable boskos leases to test this.
/override ci/prow/e2e-aws

@openshift-ci-robot
Copy link
Contributor

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/e2e-aws

In response to this:

e2e-aws is lease exhaustion; there's no reason for us to take up valuable boskos leases to test this.
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 29568c0 into openshift:master Jun 18, 2020
@cgwalters cgwalters mentioned this pull request Jun 22, 2020
Merged
@cgwalters
Copy link
Member Author

PR to add this to Prow in openshift/release#9835

cgwalters added a commit to cgwalters/release that referenced this pull request Jun 22, 2020
@cgwalters
machine-config-operator: Add /test cluster-bootimages (optional)
0c1247d 
See openshift/machine-config-operator#1836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runcom runcom Awaiting requested review from runcom

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@runcom runcom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cgwalters @openshift-ci-robot @runcom @openshift-merge-robot