Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ovirt/vsphere] Favor EtcdDiscoveryDomain in ControllerConfig.Infra.Status #1863

Merged
merged 1 commit into from Jun 25, 2020
Merged

[ovirt/vsphere] Favor EtcdDiscoveryDomain in ControllerConfig.Infra.Status #1863

merged 1 commit into from Jun 25, 2020

Conversation

mandre
Copy link
Member

@mandre mandre commented Jun 23, 2020

The EtcdDiscoveryDomain field on ControllerConfig CRD was deprecated in
[1] in favor of ControllerConfig.Infra.Status.EtcdDiscoveryDomain.
However the originial PR missed two matches.

This fixes it so that there is no surprise in case
ControllerConfig.EtcdDiscoveryDomain is effectively removed.

[1] #1675

- What I did

- How to verify it

- Description for the changelog

@mandre
Favor EtcdDiscoveryDomain in ControllerConfig.Infra.Status
57a5f3d 
The EtcdDiscoveryDomain field on ControllerConfig CRD was deprecated in
[1] in favor of `ControllerConfig.Infra.Status.EtcdDiscoveryDomain`.
However the originial PR missed two matches.

This fixes it so that there is no surprise in case
`ControllerConfig.EtcdDiscoveryDomain` is effectively removed.

[1] openshift#1675
@mandre
Copy link
Member Author

mandre commented Jun 23, 2020

/assign @LorbusChris
/cc @patrickdillon @rgolangh

@kikisdeliveryservice kikisdeliveryservice changed the title Favor EtcdDiscoveryDomain in ControllerConfig.Infra.Status [ovirt/vsphere] Favor EtcdDiscoveryDomain in ControllerConfig.Infra.Status Jun 23, 2020
@kikisdeliveryservice
Copy link
Contributor

/retest

@kikisdeliveryservice
Copy link
Contributor

/assign @rgolangh @patrickdillon

rgolangh
rgolangh reviewed Jun 24, 2020
View reviewed changes
Copy link
Contributor

@rgolangh rgolangh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ovirt

@rgolangh
Copy link
Contributor

/test e2e-ovirt
/test e2e-vshpere

@LorbusChris
Copy link
Member

Oh I must've overlooked those in a rebase.
/approve

@runcom
Copy link
Member

runcom commented Jun 24, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, mandre, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 24, 2020
@runcom
Copy link
Member

runcom commented Jun 24, 2020

/test e2e-vsphere

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@LorbusChris: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test cluster-bootimages
  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-scaleup-rhel7
  • /test e2e-azure
  • /test e2e-gcp-op
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-openstack
  • /test e2e-ovirt
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test images
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-machine-config-operator-master-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-scaleup-rhel7
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-upgrade
  • pull-ci-openshift-machine-config-operator-master-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-master-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-master-images
  • pull-ci-openshift-machine-config-operator-master-unit
  • pull-ci-openshift-machine-config-operator-master-verify

In response to this:

/test e2e-vshpere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris
Copy link
Member

/test e2e-vsphere

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 24, 2020 •
edited

@mandre: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere 57a5f3d link /test e2e-vsphere
ci/prow/e2e-aws-scaleup-rhel7 57a5f3d link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8e0c220 into openshift:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgolangh rgolangh rgolangh left review comments

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@runcom runcom Awaiting requested review from runcom

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@runcom runcom

@patrickdillon patrickdillon

@rgolangh rgolangh

@LorbusChris LorbusChris

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mandre @kikisdeliveryservice @rgolangh @LorbusChris @runcom @openshift-ci-robot @openshift-bot @patrickdillon @openshift-merge-robot