Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStack: Minimal DHCP fix to unblock CI #1865

Merged
merged 1 commit into from Jun 24, 2020
Merged

OpenStack: Minimal DHCP fix to unblock CI #1865

merged 1 commit into from Jun 24, 2020

Conversation

mandre
Copy link
Member

@mandre mandre commented Jun 23, 2020

The full fix for all platforms is #1840, but as this is completely
blocking openstack ci and dev right now and we're having ci issues with
the other platforms on the full fix, this is just the bit that is
needed to get openstack working again. We'll still want to get
1840 in eventually, but that will be less critical if we merge this in
the meantime.

Similar to what Baremetal did in #1851

@mandre
OpenStack: Minimal DHCP fix to unblock CI
8277e1d 
The full fix for all platforms is openshift#1840, but as this is completely
blocking openstack ci and dev right now and we're having ci issues with
the other platforms on the full fix, this is just the bit that is
needed to get openstack working again. We'll still want to get
1840 in eventually, but that will be less critical if we merge this in
the meantime.

Similar to what Baremetal did in openshift#1851
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
@pierreprinetti
Copy link
Member

/lgtm
/hold for e2e-openstack

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2020
@pierreprinetti
Copy link
Member

/test e2e-openstack

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierreprinetti
Copy link
Member

/hold cancel
Tested offline in conjunction with openshift/installer#3789

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2020
@kikisdeliveryservice
Copy link
Contributor

/retest

@kikisdeliveryservice
Copy link
Contributor

give these 1 more run, @pierreprinetti do you expect the openstack job to pass?

@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Jun 23, 2020
Merged
@kikisdeliveryservice
Copy link
Contributor

/retest

@kikisdeliveryservice
Copy link
Contributor

seeing:

 info: Loading sha256:fa3e06e94e71156650f88dfb3c2437069480b5dc417a350c74335e8a1c99741b operator-lifecycle-manager
info: Loading sha256:56a765655b37228ed0e1abb2db686c4adfc5bf94d4c1d3618374d61b27c49466 operator-marketplace
info: Loading sha256:4e7cbb2cf8ab0970ff99982f364f6a9b325dacd8d042dcbd8ed7c9bda8f3f783 special-resource-operator
info: Loading sha256:1a6b4a3ab08d55cbbb7fab02dec6e67fd84b86ab3380877526d99f7904a90173 service-ca-operator
info: Included 111 images from 36 input operators into the release
error: unable to convert the image to a compatible schema version: Put https://registry.svc.ci.openshift.org/v2/ci-op-3m5it6nw/release/manifests/latest: EOF

in both failing tests... let's see if it happens again, will report.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 24, 2020 •
edited

@mandre: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 8277e1d link /test e2e-openstack

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0f33cc6 into openshift:master Jun 24, 2020
@pierreprinetti
Copy link
Member

@kikisdeliveryservice
The CI is currently broken; we expected to see a green run once both this and openshift/installer#3789 were merged. Unfortunately this hasn't been the case yet; not sure yet if it's because the periodic is still running on the old images, or if this just didn't work.

@mandre
Copy link
Member Author

mandre commented Jun 24, 2020

I believe this patch helped reducing the delay for the masters and workers to come up, but there are still more issues causing the cluster to take more time than needed to stabilize.

I'm thinking https://bugzilla.redhat.com/show_bug.cgi?id=1849583 could have an impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreprinetti pierreprinetti pierreprinetti approved these changes

@adduarte adduarte Awaiting requested review from adduarte

Assignees

@pierreprinetti pierreprinetti

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mandre @pierreprinetti @openshift-ci-robot @kikisdeliveryservice @openshift-bot @openshift-merge-robot