Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1851344: Pass proxy settings nodeip-configuration service for baremetal, vsphere, openstack #1874

Merged
merged 3 commits into from Jul 10, 2020
Merged

Bug 1851344: Pass proxy settings nodeip-configuration service for baremetal, vsphere, openstack #1874

merged 3 commits into from Jul 10, 2020
+100 −0

Conversation

mandre
Copy link
Member

@mandre mandre commented Jun 26, 2020

The nodeip-configuration service used in on-premise platforms needs to
follow proxy settings otherwise it may not be able to download
container image.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 26, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Bugzilla bug 1851344, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1851344: Pass proxy settings nodeip-configuration service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member Author

mandre commented Jun 26, 2020

/test e2e-openstack

@kikisdeliveryservice
Copy link
Contributor

/retest

@kikisdeliveryservice
Copy link
Contributor

/test e2e-vsphere

@kikisdeliveryservice kikisdeliveryservice changed the title Bug 1851344: Pass proxy settings nodeip-configuration service Bug 1851344: Pass proxy settings nodeip-configuration service for baremetal, vsphere, openstack Jun 26, 2020
@kikisdeliveryservice
Copy link
Contributor

/assign @pierreprinetti @cybertron @jcpowermac

@kikisdeliveryservice
Copy link
Contributor

/retest

@pierreprinetti
Copy link
Member

/test e2e-openstack

@mandre
Copy link
Member Author

mandre commented Jun 29, 2020

For some reason, github didn't pick my last commit so I had to rebase and force push the branch...

/test e2e-openstack
/test e2e-ovirt
/test e2e-vshpere

@mandre
Copy link
Member Author

mandre commented Jun 29, 2020

/test e2e-openstack

@mandre
Copy link
Member Author

mandre commented Jun 29, 2020

/retest

@kikisdeliveryservice
Copy link
Contributor

upgrade job seems broke-ish ill check in 4-dev

@cybertron
Copy link
Member

Seems fine to me, assuming it passes ci.

@mandre
Copy link
Member Author

mandre commented Jun 30, 2020

/retest

2 similar comments
@mandre
Copy link
Member Author

mandre commented Jul 1, 2020

/retest

@pierreprinetti
Copy link
Member

/retest

@pierreprinetti
Copy link
Member

/test e2e-gcp-upgrade

@mandre
Bug 1851344: Pass proxy settings nodeip-configuration service
9bb771c 
The nodeip-configuration service used in on-premise platforms needs to
follow proxy settings otherwise it may not be able to download
container image.
@mandre
Use proxy settings in NM resolv prepender script
a091083 
This ensures the script will be able to pull the container images when
running behind a proxy.
@mandre
Use proxy settings in machine-config-daemon-firstboot service
40cfab6 
This allows pulling container images when behind a proxy.
@mandre
Copy link
Member Author

mandre commented Jul 4, 2020

/test e2e-vsphere
/test e2e-ovirt
/test e2e-openstack

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 9, 2020
@mandre
Copy link
Member Author

mandre commented Jul 9, 2020

/hold cancel
This should be good to merge.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2020
@runcom
Copy link
Member

runcom commented Jul 9, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, pierreprinetti, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

16 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@mandre: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere 40cfab6 link /test e2e-vsphere
ci/prow/e2e-ovirt 40cfab6 link /test e2e-ovirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e50305a into openshift:master Jul 10, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1874. Bugzilla bug 1851344 has been moved to the MODIFIED state.

In response to this:

Bug 1851344: Pass proxy settings nodeip-configuration service for baremetal, vsphere, openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 6, 2020
Merged
@openshift-cherrypick-robot
Copy link

@pierreprinetti: new pull request created: #1985

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adduarte adduarte Awaiting requested review from adduarte

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees

@cybertron cybertron

@pierreprinetti pierreprinetti

@jcpowermac jcpowermac

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet