Bug 1805019: KubeletConfig: Verify EvictionSoftGracePeriod is set when EvictionSof…

[harche]

- What I did
Fixes - https://bugzilla.redhat.com/show_bug.cgi?id=1805019

- How to verify it
Try to create a KubeletConfig with EvictionSoft but without EvictionSoftGracePeriod and while describing the kubeletconfig, oc describe KubeletConfig worker-kubeconfig-fix you should be able to see the error,

      Custom - Kubelet:  small-pods
Status:
  Conditions:
    Last Transition Time:  2020-06-30T11:57:34Z
    Message:               Error: KubeletConfiguration: EvictionSoftGracePeriod must be set when evictionSoft is defined, evictionSoft: map[memory.available:90% nodefs.available:90% nodefs.inodesFree:90%]
    Status:                False
    Type:                  Failure

- Description for the changelog
Making sure EvictionSoftGracePeriod is specified when EvictionSoft in KubeletConfig

[openshift-ci-robot]

@harche: This pull request references Bugzilla bug 1805019, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1805019: KubeletConfig: Verify EvictionSoftGracePeriod is set when EvictionSof…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[harche]

/assign @kikisdeliveryservice

[openshift-ci-robot]

@harche: This pull request references Bugzilla bug 1805019, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1805019: KubeletConfig: Verify EvictionSoftGracePeriod is set when EvictionSof…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@harche: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	6574540	link	/test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[kikisdeliveryservice]

/hold

[runcom]

I think this check works but that we should also check when it's created so that we don't create an incorrect KC in the first place. Probably like here in validateUserKubeletConfig: https://github.com/openshift/machine-config-operator/blob/master/pkg/controller/kubelet-config/helpers.go#L90

I think this PR is indeed adding validation in validateUserKubeletConfig right?

[harche]

I think this check works but that we should also check when it's created so that we don't create an incorrect KC in the first place. Probably like here in validateUserKubeletConfig: https://github.com/openshift/machine-config-operator/blob/master/pkg/controller/kubelet-config/helpers.go#L90

I think this PR is indeed adding validation in validateUserKubeletConfig right?

Yes

[runcom]

leaving to Ryan to lgtm

/approve

[rphillips]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, rphillips, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[runcom]

/hold cancel

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@harche: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1880. Bugzilla bug 1805019 has been moved to the MODIFIED state.

In response to this:

Bug 1805019: KubeletConfig: Verify EvictionSoftGracePeriod is set when EvictionSof…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[harche]

/cherry-pick 4.5

[openshift-cherrypick-robot]

@harche: cannot checkout 4.5: error checking out 4.5: exit status 1. output: error: pathspec '4.5' did not match any file(s) known to git.

In response to this:

/cherry-pick 4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[harche]

/cherry-pick release-4.5

[openshift-cherrypick-robot]

@harche: new pull request created: #1887

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[harche]

/cherry-pick release-4.4

[openshift-cherrypick-robot]

@harche: new pull request created: #1888

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.