Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1821800: Revert "OpenStack: disable tx checksum offload for workers" #1882

Merged

Conversation

mandre
Copy link
Member

@mandre mandre commented Jun 30, 2020

RHCOS image now contains the fix for nodeport service running on
different hosts, allowing us to remove the partial workaround.

The fix landed in kernel-4.18.0-202.el8 [1],
kernel-4.18.0-193.10.1.el8_2 [2], and kernel-4.18.0-147.21.1.el8_1 [3].

This reverts commit 270bb67.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1847128
[3] https://bugzilla.redhat.com/show_bug.cgi?id=1847127

RHCOS image now contains the fix for nodeport service running on
different hosts, allowing us to remove the partial workaround.

The fix landed in kernel-4.18.0-202.el8 [1],
kernel-4.18.0-193.10.1.el8_2 [2], and kernel-4.18.0-147.21.1.el8_1 [3].

This reverts commit 270bb67.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1847128
[3] https://bugzilla.redhat.com/show_bug.cgi?id=1847127
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 30, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Bugzilla bug 1821800, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1821800: Revert "OpenStack: disable tx checksum offload for workers"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020
@pierreprinetti
Copy link
Member

/test e2e-openstack

@kikisdeliveryservice
Copy link
Contributor

/retest

2 similar comments
@kikisdeliveryservice
Copy link
Contributor

/retest

@mandre
Copy link
Member Author

mandre commented Jul 9, 2020

/retest

@mandre
Copy link
Member Author

mandre commented Jul 9, 2020

/test e2e-gcp-upgrade

@pierreprinetti
Copy link
Member

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8d0abf1 into openshift:master Jul 9, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1882. Bugzilla bug 1821800 has been moved to the MODIFIED state.

In response to this:

Bug 1821800: Revert "OpenStack: disable tx checksum offload for workers"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants