tests/e2e: Refactor and reduce test run time #1884
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
kikisdeliveryservice
force-pushed
the
refactor-e2e
branch
from
15e74a5
to
cdad590
Compare
|
/skip |
1 similar comment
|
/skip |
openshift-ci-robot
added
the
needs-rebase
kikisdeliveryservice
force-pushed
the
refactor-e2e
branch
from
cdad590
to
fb9adc0
Compare
openshift-ci-robot
removed
the
needs-rebase
|
|
kikisdeliveryservice
force-pushed
the
refactor-e2e
branch
3 times, most recently
from
9936974
to
e4a3f1f
Compare
|
Got this fixed locally will repush tomorrow. |
kikisdeliveryservice
force-pushed
the
refactor-e2e
branch
from
e4a3f1f
to
dd0beec
Compare
|
/skip |
|
So I decided to shoot the moon even tho I got the e2e down to ~62 min and use custom pools for kargs.. That's when it all went south. I think there's an issue rolling back - I opened #1912 to test (also deleted all the other e2e so hopefully it runs a lot faster over there too): Ok seeing same error in this ci run that I saw in my local cluster: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/1884/pull-ci-openshift-machine-config-operator-master-e2e-gcp-op/1280664102313660416/artifacts/e2e-gcp-op/machineconfigpools.json |
|
Ok will update our test karg arguments as there seems to be a bug in rpmostree : #1912 (comment) |
openshift-ci-robot
added
the
needs-rebase
kikisdeliveryservice
force-pushed
the
refactor-e2e
branch
from
f9ec554
to
486656f
Compare
openshift-ci-robot
removed
the
needs-rebase
kikisdeliveryservice
force-pushed
the
refactor-e2e
branch
2 times, most recently
from
9f1b7b2
to
d8b4f7d
Compare
|
Fixing test kargs allowed rollback to run sucessfully. Last successful test run was 55m. |
openshift-ci-robot
added
the
needs-rebase
kikisdeliveryservice
force-pushed
the
refactor-e2e
branch
from
4f228aa
to
afda24f
Compare
kikisdeliveryservice
requested review from
runcom
and removed request for
runcom
|
Test started last Wednesday at 10:20 AM passed after 2h27m45s. I'd say... 😌 /approve |
kikisdeliveryservice
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
kikisdeliveryservice
changed the title
|
@runcom this is ready whenever you are 😸 |
|
/skip |
|
/retest |
|
Didn't deep dive but LGTM overall! In the future one thing we can consider is using temporary machinesets too (gets into #1720 ) - we can parallelize the tests arbitrarily by having a MCP+machineset per test scenario (at the cost of more $ of course). |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
@kikisdeliveryservice: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
this is a test refactor in e2e-gcp-op, there's not reason to keep retesting on the known broken e2e-aws and waste resources since this doesn't touch at that all and it's retesting a billion times at this point /override e2e-aws |
|
@kikisdeliveryservice: /override requires a failed status context to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws |
|
@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Refactor mco e2e tests and reduce time of the e2e tests by ~50% by removing duplicative tests & using custom pools. Current runtime based on this PR is ~55m for the mco e2e tests to run down from ~100min.