templates: Fix for NM dispatcher script miscounting length #1906
Conversation
Use `printf` instead of `echo` when truncating the hostname. `echo` adds line termination that gets counted as a character. Example: $ echo test | wc -c 5 $ printf test | wc -c 4 Signed-off-by: Ben Howard <ben.howard@redhat.com>
kikisdeliveryservice
changed the title
|
/retest |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, darkmuggle, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@darkmuggle: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Use
printfinstead ofechowhen truncating the hostname.echoaddsline termination that gets counted as a character. Example:
$ echo test | wc -c
5
$ printf test | wc -c
4
Signed-off-by: Ben Howard <ben.howard@redhat.com